qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Juan Quintela <quintela@redhat.com>,
	patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/2] pflash_cfi01: Drop unused 'bypass' field
Date: Tue, 19 Mar 2013 18:24:28 +0000	[thread overview]
Message-ID: <1363717469-30980-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1363717469-30980-1-git-send-email-peter.maydell@linaro.org>

For pflash_cfi01 the 'bypass' field is set to zero and never changes,
so remove it (it is a leftover from pflash_cfi02, where bypass is
implemented).

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/pflash_cfi01.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c
index 5d57bab..20d10b3 100644
--- a/hw/pflash_cfi01.c
+++ b/hw/pflash_cfi01.c
@@ -68,7 +68,6 @@ struct pflash_t {
     uint8_t width;
     uint8_t be;
     int wcycle; /* if 0, the flash is read normally */
-    int bypass;
     int ro;
     uint8_t cmd;
     uint8_t status;
@@ -93,12 +92,8 @@ static void pflash_timer (void *opaque)
     DPRINTF("%s: command %02x done\n", __func__, pfl->cmd);
     /* Reset flash */
     pfl->status ^= 0x80;
-    if (pfl->bypass) {
-        pfl->wcycle = 2;
-    } else {
-        memory_region_rom_device_set_readable(&pfl->mem, true);
-        pfl->wcycle = 0;
-    }
+    memory_region_rom_device_set_readable(&pfl->mem, true);
+    pfl->wcycle = 0;
     pfl->cmd = 0;
 }
 
@@ -452,7 +447,6 @@ static void pflash_write(pflash_t *pfl, hwaddr offset,
  reset_flash:
     memory_region_rom_device_set_readable(&pfl->mem, true);
 
-    pfl->bypass = 0;
     pfl->wcycle = 0;
     pfl->cmd = 0;
 }
-- 
1.7.9.5

  reply	other threads:[~2013-03-19 18:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 18:24 [Qemu-devel] [PATCH 0/2] Implement migration support for pflash_cfi01 Peter Maydell
2013-03-19 18:24 ` Peter Maydell [this message]
2013-03-19 18:24 ` [Qemu-devel] [PATCH 2/2] pflash_cfi01: Implement migration support Peter Maydell
2013-03-26 13:32   ` Peter Maydell
2013-03-21  7:45 ` [Qemu-devel] Use of flash for x86 BIOS (was: [PATCH 0/2] Implement migration support for pflash_cfi01) Markus Armbruster
2013-03-22 16:42   ` Peter Maydell
2013-03-22 18:51     ` [Qemu-devel] Use of flash for x86 BIOS Markus Armbruster
2013-03-22 19:09   ` [Qemu-devel] Use of flash for x86 BIOS (was: [PATCH 0/2] Implement migration support for pflash_cfi01) Jordan Justen
2013-03-22 19:48     ` [Qemu-devel] Use of flash for x86 BIOS Markus Armbruster
2013-04-03 13:48       ` Laszlo Ersek
2013-04-03 18:38       ` Jordan Justen
2013-04-12 15:33         ` Markus Armbruster
2013-04-08  6:06     ` Xiao Guangrong
2013-04-08  8:18       ` Jordan Justen
2013-04-08  8:43         ` Gleb Natapov
2013-04-08  9:19           ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363717469-30980-2-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=aliguori@us.ibm.com \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).