From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8HH-0004Uq-4H for qemu-devel@nongnu.org; Tue, 19 Mar 2013 21:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI8HA-0007Hk-Tl for qemu-devel@nongnu.org; Tue, 19 Mar 2013 21:57:19 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:56250 helo=linux-iscsi.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8HA-0007Hf-PK for qemu-devel@nongnu.org; Tue, 19 Mar 2013 21:57:12 -0400 From: "Nicholas A. Bellinger" In-Reply-To: <20130319084057.GB24393@stefanha-thinkpad.redhat.com> References: <1363653285-23776-1-git-send-email-asias@redhat.com> <1363653285-23776-4-git-send-email-asias@redhat.com> <20130319084057.GB24393@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 19 Mar 2013 18:57:08 -0700 Message-ID: <1363744628.13070.28.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, target-devel@vger.kernel.org, Stefan Hajnoczi , Paolo Bonzini , Asias He On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > > --- > > hw/vhost.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/vhost.c b/hw/vhost.c > > index 4d6aee3..0c52ec4 100644 > > --- a/hw/vhost.c > > +++ b/hw/vhost.c > > @@ -421,10 +421,12 @@ static void vhost_set_memory(MemoryListener *listener, > > return; > > } > > > > +#if 0 > > if (dev->started) { > > r = vhost_verify_ring_mappings(dev, start_addr, size); > > assert(r >= 0); > > } > > +#endif > > Please add a comment to explain why. > Btw, the output that Asias added in the failure case at the behest of MST is here: http://www.spinics.net/lists/target-devel/msg04077.html MST seemed to think it may be a bug in cpu_physical_memory_map, but as this worked with the original vhost-scsi code it would seem to indicate something else at fault.. I'll be comparing what the original code did vs. vhost-scsi-pci to track this down, but any extra ideas to track is down is appreciated. ;) --nab