From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIB0w-00062Y-QF for qemu-devel@nongnu.org; Wed, 20 Mar 2013 00:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIB0v-0006L8-Pe for qemu-devel@nongnu.org; Wed, 20 Mar 2013 00:52:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIB0v-0006L2-Hc for qemu-devel@nongnu.org; Wed, 20 Mar 2013 00:52:37 -0400 Message-ID: <1363755154.24132.485.camel@bling.home> From: Alex Williamson Date: Tue, 19 Mar 2013 22:52:34 -0600 In-Reply-To: <20130319230808.GC20332@morn.localdomain> References: <20130319030657.14697.64825.stgit@bling.home> <20130319230808.GC20332@morn.localdomain> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin O'Connor Cc: seabios@seabios.org, qemu-devel@nongnu.org On Tue, 2013-03-19 at 19:08 -0400, Kevin O'Connor wrote: > On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote: > > As QEMU gains PCI bridge and PCIe root port support, we won't always > > find the VGA device on the root bus. We therefore need to add support > > to find and enable a VGA device and the path to it through the VGA > > Enable support in the PCI bridge control register. > > Thanks. I'm okay with the change. It would be nice if someone more > familiar with the QEMU side could ack this patch. > > As a minor nitpick - there is a pci_config_maskw() that would simplify > your code. Ah, that does clean it up a bit. Actually, hold off on this patch. I'm getting VGA routing setup as I expect, but guests are not happy with the other apertures on the bridges and I'm not sure if I'm contributing to that problem yet. Thanks, Alex