From: Alex Williamson <alex.williamson@redhat.com>
To: Kevin O'Connor <kevin@koconnor.net>
Cc: seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device
Date: Tue, 19 Mar 2013 23:45:26 -0600 [thread overview]
Message-ID: <1363758326.24132.491.camel@bling.home> (raw)
In-Reply-To: <1363755154.24132.485.camel@bling.home>
On Tue, 2013-03-19 at 22:52 -0600, Alex Williamson wrote:
> On Tue, 2013-03-19 at 19:08 -0400, Kevin O'Connor wrote:
> > On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote:
> > > As QEMU gains PCI bridge and PCIe root port support, we won't always
> > > find the VGA device on the root bus. We therefore need to add support
> > > to find and enable a VGA device and the path to it through the VGA
> > > Enable support in the PCI bridge control register.
> >
> > Thanks. I'm okay with the change. It would be nice if someone more
> > familiar with the QEMU side could ack this patch.
> >
> > As a minor nitpick - there is a pci_config_maskw() that would simplify
> > your code.
>
> Ah, that does clean it up a bit. Actually, hold off on this patch. I'm
> getting VGA routing setup as I expect, but guests are not happy with the
> other apertures on the bridges and I'm not sure if I'm contributing to
> that problem yet. Thanks,
Turns out it's this:
commit 76e58028d28e78431f9de3cee0b3c88d807fa39d
Author: Kevin O'Connor <kevin@koconnor.net>
Date: Wed Mar 6 21:50:09 2013 -0500
acpi: Eliminate BDAT parameter passing to DSDT code.
The "BDAT" construct is the only ACPI mechanism that relies on SeaBIOS
reserved memory. Replace it with the SSDT based template system.
Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
I'll look at it more tomorrow, I should already be asleep by now. When
I boot a linux guest on qemu with a device behind a bridge I see "no
compatible bridge window for <range>" messages and the apertures get
de-programmed. So I think the VGA patch here still works, but it's kind
of useless as only the VGA ranges get routed and we can't even get to
VESA modes because of the apertures getting shutdown. Thanks,
Alex
next prev parent reply other threads:[~2013-03-20 5:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 3:07 [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device Alex Williamson
2013-03-19 23:08 ` Kevin O'Connor
2013-03-20 4:52 ` Alex Williamson
2013-03-20 5:45 ` Alex Williamson [this message]
2013-03-20 7:17 ` Gerd Hoffmann
2013-03-20 16:18 ` Alex Williamson
2013-03-20 16:46 ` Gerd Hoffmann
2013-03-20 16:55 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363758326.24132.491.camel@bling.home \
--to=alex.williamson@redhat.com \
--cc=kevin@koconnor.net \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).