From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIC0s-0003Ye-S9 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 01:56:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIC0p-00036a-GH for qemu-devel@nongnu.org; Wed, 20 Mar 2013 01:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIC0p-00036I-8W for qemu-devel@nongnu.org; Wed, 20 Mar 2013 01:56:35 -0400 From: Asias He Date: Wed, 20 Mar 2013 13:56:08 +0800 Message-Id: <1363758968-28549-1-git-send-email-asias@redhat.com> Subject: [Qemu-devel] [PATCH] virtio-blk: Set default serial id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Asias He , kvm@vger.kernel.org, Stefan Hajnoczi If user does not specify a serial id, e.g. -device virtio-blk-pci,serial="serial_id" or -drive serial="serial_id" no serial id will be assigned. Add a default serial id in this case to help identifying the disk in guest. Signed-off-by: Asias He --- hw/virtio-blk.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index f2143fd..c016817 100644 --- a/hw/virtio-blk.c +++ b/hw/virtio-blk.c @@ -642,6 +642,13 @@ static int virtio_blk_device_init(VirtIODevice *vdev) } blkconf_serial(&blk->conf, &blk->serial); + + if (!blk->serial) { + char serial[VIRTIO_BLK_ID_BYTES]; + snprintf(serial, VIRTIO_BLK_ID_BYTES, "ID%05d", virtio_blk_id); + blk->serial = g_strdup(serial); + } + if (blkconf_geometry(&blk->conf, NULL, 65535, 255, 255) < 0) { return -1; } -- 1.8.1.4