From: Orit Wasserman <owasserm@redhat.com>
To: qemu-devel@nongnu.org
Cc: Orit Wasserman <owasserm@redhat.com>,
pbonzini@redhat.com, mst@redhat.com, chegu_vinod@hp.com,
quintela@redhat.com
Subject: [Qemu-devel] [RFC 11/12] Use qemu_put_buffer_no_copy for guest memory pages
Date: Thu, 21 Mar 2013 11:09:30 +0200 [thread overview]
Message-ID: <1363856971-4601-12-git-send-email-owasserm@redhat.com> (raw)
In-Reply-To: <1363856971-4601-1-git-send-email-owasserm@redhat.com>
This will remove an unneeded copy of guest memory pages.
For the page header and device state we still copy the data to the
static buffer the other option is to allocate the memory on demand
which is more expensive.
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
arch_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch_init.c b/arch_init.c
index 98e2bc6..27b53eb 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -481,7 +481,7 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
/* XBZRLE overflow or normal page */
if (bytes_sent == -1) {
bytes_sent = save_block_hdr(f, block, offset, cont, RAM_SAVE_FLAG_PAGE);
- qemu_put_buffer(f, p, TARGET_PAGE_SIZE);
+ qemu_put_buffer_no_copy(f, p, TARGET_PAGE_SIZE);
bytes_sent += TARGET_PAGE_SIZE;
acct_info.norm_pages++;
}
--
1.7.11.7
next prev parent reply other threads:[~2013-03-21 9:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 9:09 [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 01/12] Add iov_writev to use writev to send iovec (also for files) Orit Wasserman
2013-03-21 9:23 ` Paolo Bonzini
2013-03-21 9:09 ` [Qemu-devel] [RFC 02/12] Add QemuFileWritevBuffer QemuFileOps Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function Orit Wasserman
2013-03-21 9:18 ` Paolo Bonzini
2013-03-21 9:47 ` Orit Wasserman
2013-03-21 9:47 ` Paolo Bonzini
2013-03-21 10:17 ` Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 04/12] Add stdio_writev_buffer function Orit Wasserman
2013-03-21 9:28 ` Paolo Bonzini
2013-03-21 9:09 ` [Qemu-devel] [RFC 05/12] Add block_writev_buffer function Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 06/12] Update bytes_xfer in qemu_put_byte Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 07/12] Store the data to send also in iovec Orit Wasserman
2013-03-21 9:56 ` Paolo Bonzini
2013-03-21 11:10 ` Orit Wasserman
2013-03-21 11:14 ` Michael S. Tsirkin
2013-03-21 12:50 ` Orit Wasserman
2013-03-21 13:00 ` Paolo Bonzini
2013-03-21 9:09 ` [Qemu-devel] [RFC 08/12] Use writev ops instead of put_buffer ops Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 09/12] More optimized qemu_put_be64/32/16 Orit Wasserman
2013-03-21 9:09 ` [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy Orit Wasserman
2013-03-21 9:25 ` Paolo Bonzini
2013-03-23 16:27 ` Michael R. Hines
2013-03-25 8:11 ` Orit Wasserman
2013-03-25 13:05 ` Paolo Bonzini
2013-03-25 15:18 ` Michael R. Hines
2013-03-25 15:59 ` Paolo Bonzini
2013-03-21 9:09 ` Orit Wasserman [this message]
2013-03-21 9:09 ` [Qemu-devel] [RFC 12/12] Bye Bye put_buffer Orit Wasserman
2013-03-21 9:29 ` [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages Paolo Bonzini
2013-03-21 10:05 ` Orit Wasserman
2013-03-21 9:48 ` Michael S. Tsirkin
2013-03-21 9:53 ` Paolo Bonzini
2013-03-21 11:09 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363856971-4601-12-git-send-email-owasserm@redhat.com \
--to=owasserm@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).