From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIgp6-0003AC-SY for qemu-devel@nongnu.org; Thu, 21 Mar 2013 10:50:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIgp2-0002Hq-AM for qemu-devel@nongnu.org; Thu, 21 Mar 2013 10:50:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIgp2-0002HQ-33 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 10:50:28 -0400 From: Stefan Hajnoczi Date: Thu, 21 Mar 2013 15:49:59 +0100 Message-Id: <1363877399-16339-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1363877399-16339-1-git-send-email-stefanha@redhat.com> References: <1363877399-16339-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [RFC 4/4] block: clean up I/O throttling wait_time code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?q?Beno=C3=AEt=20Canet?= , Stefan Hajnoczi , Zhi Yong Wu The wait_time variable is in seconds. Reflect this in a comment and use NANOSECONDS_PER_SECOND instead of BLOCK_IO_SLICE_TIME * 10 (which happens to have the right value). Signed-off-by: Stefan Hajnoczi --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index fed3b4d..ff862a0 100644 --- a/block.c +++ b/block.c @@ -3698,7 +3698,7 @@ static bool bdrv_exceed_bps_limits(BlockDriverState *bs, int nb_sectors, BLOCK_IO_SLICE_TIME; bs->slice_end += extension; if (wait) { - *wait = wait_time * BLOCK_IO_SLICE_TIME * 10; + *wait = wait_time * NANOSECONDS_PER_SECOND; } return true; @@ -3740,7 +3740,7 @@ static bool bdrv_exceed_iops_limits(BlockDriverState *bs, bool is_write, return false; } - /* Calc approx time to dispatch */ + /* Calc approx time to dispatch, in seconds */ wait_time = (ios_base + 1) / iops_limit; if (wait_time > elapsed_time) { wait_time = wait_time - elapsed_time; @@ -3751,7 +3751,7 @@ static bool bdrv_exceed_iops_limits(BlockDriverState *bs, bool is_write, /* Exceeded current slice, extend it by another slice time */ bs->slice_end += BLOCK_IO_SLICE_TIME; if (wait) { - *wait = wait_time * BLOCK_IO_SLICE_TIME * 10; + *wait = wait_time * NANOSECONDS_PER_SECOND; } return true; -- 1.8.1.4