From: Orit Wasserman <owasserm@redhat.com>
To: qemu-devel@nongnu.org
Cc: Orit Wasserman <owasserm@redhat.com>,
pbonzini@redhat.com, mst@redhat.com, chegu_vinod@hp.com,
quintela@redhat.com
Subject: [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs
Date: Thu, 21 Mar 2013 18:05:40 +0200 [thread overview]
Message-ID: <1363881940-27505-10-git-send-email-owasserm@redhat.com> (raw)
In-Reply-To: <1363881940-27505-1-git-send-email-owasserm@redhat.com>
This way we send one big buffer instead of many small ones
Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
savevm.c | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/savevm.c b/savevm.c
index 50e8fb2..13a533b 100644
--- a/savevm.c
+++ b/savevm.c
@@ -634,8 +634,14 @@ void qemu_put_buffer_no_copy(QEMUFile *f, const uint8_t *buf, int size)
abort();
}
- f->iov[f->iovcnt].iov_base = (uint8_t *)buf;
- f->iov[f->iovcnt++].iov_len = size;
+ /* check for adjoint buffer and colace them */
+ if (f->iovcnt > 0 && buf == f->iov[f->iovcnt - 1].iov_base +
+ f->iov[f->iovcnt - 1].iov_len) {
+ f->iov[f->iovcnt - 1].iov_len += size;
+ } else {
+ f->iov[f->iovcnt].iov_base = (uint8_t *)buf;
+ f->iov[f->iovcnt++].iov_len = size;
+ }
f->is_write = 1;
f->bytes_xfer += size;
@@ -690,8 +696,15 @@ void qemu_put_byte(QEMUFile *f, int v)
f->buf[f->buf_index++] = v;
f->is_write = 1;
f->bytes_xfer += 1;
- f->iov[f->iovcnt].iov_base = f->buf + (f->buf_index - 1);
- f->iov[f->iovcnt++].iov_len = 1;
+
+ /* check for adjoint buffer and colace them */
+ if (f->iovcnt > 0 && f->buf + (f->buf_index - 1) ==
+ f->iov[f->iovcnt - 1].iov_base + f->iov[f->iovcnt - 1].iov_len) {
+ f->iov[f->iovcnt - 1].iov_len += 1;
+ } else {
+ f->iov[f->iovcnt].iov_base = f->buf + (f->buf_index - 1);
+ f->iov[f->iovcnt++].iov_len = 1;
+ }
if (f->buf_index >= IO_BUF_SIZE || f->iovcnt >= MAX_IOV_SIZE) {
qemu_fflush(f);
--
1.7.11.7
next prev parent reply other threads:[~2013-03-21 16:05 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-21 16:05 [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 1/9] Add QemuFileWritevBuffer QemuFileOps Orit Wasserman
2013-03-21 16:57 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function Orit Wasserman
2013-03-21 16:55 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte Orit Wasserman
2013-03-21 17:06 ` Juan Quintela
2013-03-21 17:38 ` Eric Blake
2013-03-21 17:41 ` Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 4/9] Store the data to send also in iovec Orit Wasserman
2013-03-21 17:11 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 5/9] Use writev ops if available Orit Wasserman
2013-03-21 17:17 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 6/9] More optimized qemu_put_be64/32/16 Orit Wasserman
2013-03-21 17:18 ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 7/9] Add qemu_put_buffer_no_copy Orit Wasserman
2013-03-21 17:34 ` Juan Quintela
2013-03-21 17:39 ` Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 8/9] Use qemu_put_buffer_no_copy for guest memory pages Orit Wasserman
2013-03-21 16:14 ` Michael S. Tsirkin
2013-03-21 17:37 ` Juan Quintela
2013-03-21 18:08 ` Orit Wasserman
2013-03-21 18:21 ` Michael S. Tsirkin
2013-03-21 16:05 ` Orit Wasserman [this message]
2013-03-21 16:16 ` [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs Michael S. Tsirkin
2013-03-21 16:27 ` Orit Wasserman
2013-03-21 16:29 ` Michael S. Tsirkin
2013-03-21 16:40 ` Orit Wasserman
2013-03-21 17:10 ` Michael S. Tsirkin
2013-03-21 17:44 ` Juan Quintela
2013-03-21 17:46 ` Michael S. Tsirkin
2013-03-21 18:22 ` Juan Quintela
2013-03-21 18:33 ` Michael S. Tsirkin
2013-03-21 17:41 ` Juan Quintela
2013-03-21 17:12 ` [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Paolo Bonzini
2013-03-21 17:35 ` Orit Wasserman
2013-03-21 17:42 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363881940-27505-10-git-send-email-owasserm@redhat.com \
--to=owasserm@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).