qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Orit Wasserman <owasserm@redhat.com>
To: qemu-devel@nongnu.org
Cc: Orit Wasserman <owasserm@redhat.com>,
	pbonzini@redhat.com, mst@redhat.com, chegu_vinod@hp.com,
	quintela@redhat.com
Subject: [Qemu-devel] [PATCH v3 5/9] Use writev ops if available
Date: Thu, 21 Mar 2013 18:05:36 +0200	[thread overview]
Message-ID: <1363881940-27505-6-git-send-email-owasserm@redhat.com> (raw)
In-Reply-To: <1363881940-27505-1-git-send-email-owasserm@redhat.com>

Update qemu_fflush and stdio_close to use writev ops if they are available
Use the buffers stored in the iovec.

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
---
 savevm.c | 30 +++++++++++++++++++++++-------
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/savevm.c b/savevm.c
index ab81dd3..f69dce3 100644
--- a/savevm.c
+++ b/savevm.c
@@ -292,7 +292,7 @@ static int stdio_fclose(void *opaque)
     QEMUFileStdio *s = opaque;
     int ret = 0;
 
-    if (s->file->ops->put_buffer) {
+    if (s->file->ops->put_buffer || s->file->ops->writev_buffer) {
         int fd = fileno(s->stdio_file);
         struct stat st;
 
@@ -515,24 +515,40 @@ static void qemu_file_set_error(QEMUFile *f, int ret)
     }
 }
 
-/** Flushes QEMUFile buffer
+/**
+ * Flushes QEMUFile buffer
  *
+ * If there is writev_buffer QEMUFileOps it uses it otherwise uses
+ * put_buffer ops.
  */
 static void qemu_fflush(QEMUFile *f)
 {
     int ret = 0;
+    int i = 0;
 
-    if (!f->ops->put_buffer) {
+    if (!f->ops->writev_buffer && !f->ops->put_buffer) {
         return;
     }
-    if (f->is_write && f->buf_index > 0) {
-        ret = f->ops->put_buffer(f->opaque, f->buf, f->pos, f->buf_index);
-        if (ret >= 0) {
-            f->pos += f->buf_index;
+
+    if (f->is_write && f->iovcnt > 0) {
+        if (f->ops->writev_buffer) {
+            ret = f->ops->writev_buffer(f->opaque, f->iov, f->iovcnt);
+            if (ret >= 0) {
+                f->pos += ret;
+            }
+        } else {
+            for (i = 0; i < f->iovcnt && ret >= 0; i++) {
+                ret = f->ops->put_buffer(f->opaque, f->iov[i].iov_base, f->pos,
+                                         f->iov[i].iov_len);
+                if (ret >= 0) {
+                    f->pos += ret;
+                }
+            }
         }
         f->buf_index = 0;
         f->iovcnt = 0;
     }
+
     if (ret < 0) {
         qemu_file_set_error(f, ret);
     }
-- 
1.7.11.7

  parent reply	other threads:[~2013-03-21 16:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 16:05 [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 1/9] Add QemuFileWritevBuffer QemuFileOps Orit Wasserman
2013-03-21 16:57   ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 2/9] Add socket_writev_buffer function Orit Wasserman
2013-03-21 16:55   ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 3/9] Update bytes_xfer in qemu_put_byte Orit Wasserman
2013-03-21 17:06   ` Juan Quintela
2013-03-21 17:38   ` Eric Blake
2013-03-21 17:41     ` Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 4/9] Store the data to send also in iovec Orit Wasserman
2013-03-21 17:11   ` Juan Quintela
2013-03-21 16:05 ` Orit Wasserman [this message]
2013-03-21 17:17   ` [Qemu-devel] [PATCH v3 5/9] Use writev ops if available Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 6/9] More optimized qemu_put_be64/32/16 Orit Wasserman
2013-03-21 17:18   ` Juan Quintela
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 7/9] Add qemu_put_buffer_no_copy Orit Wasserman
2013-03-21 17:34   ` Juan Quintela
2013-03-21 17:39     ` Orit Wasserman
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 8/9] Use qemu_put_buffer_no_copy for guest memory pages Orit Wasserman
2013-03-21 16:14   ` Michael S. Tsirkin
2013-03-21 17:37   ` Juan Quintela
2013-03-21 18:08     ` Orit Wasserman
2013-03-21 18:21       ` Michael S. Tsirkin
2013-03-21 16:05 ` [Qemu-devel] [PATCH v3 9/9] coalesce adjacent iovecs Orit Wasserman
2013-03-21 16:16   ` Michael S. Tsirkin
2013-03-21 16:27     ` Orit Wasserman
2013-03-21 16:29       ` Michael S. Tsirkin
2013-03-21 16:40         ` Orit Wasserman
2013-03-21 17:10           ` Michael S. Tsirkin
2013-03-21 17:44         ` Juan Quintela
2013-03-21 17:46           ` Michael S. Tsirkin
2013-03-21 18:22             ` Juan Quintela
2013-03-21 18:33               ` Michael S. Tsirkin
2013-03-21 17:41   ` Juan Quintela
2013-03-21 17:12 ` [Qemu-devel] [PATCH v3 0/9] Migration: Remove copying of guest ram pages Paolo Bonzini
2013-03-21 17:35   ` Orit Wasserman
2013-03-21 17:42 ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363881940-27505-6-git-send-email-owasserm@redhat.com \
    --to=owasserm@redhat.com \
    --cc=chegu_vinod@hp.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).