qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>, patches@linaro.org
Subject: [Qemu-devel] [PATCH v2 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8
Date: Mon, 25 Mar 2013 22:31:30 +0000	[thread overview]
Message-ID: <1364250694-7939-1-git-send-email-peter.maydell@linaro.org> (raw)

These patches fix various compiler and runtime warnings QEMU provokes
on MacOSX 10.8. The first two fix a leak and some deprecated functions
which cause warnings in the system log when QEMU runs. The second
two avoid some functions which cause compile time warnings about
use of functions deprecated in 10.6.

I believe from my reading of the documentation that these changes
should still work OK on 10.3, but I don't have any way of testing that.

Andreas: I don't write much ObjC so I don't really have a feel for
what is good coding style. I mostly tried to follow the existing
code (eg "//" style comments) and QEMU's C style (eg 80 cols max).
I'm happy to change any of the indentation or whatever to suit your
preferences.

With this patch set the only remaining compile time warnings from clang
on 10.8 are about deprecated methods in audio/coreaudio.c.

Changes v1->v2:
 * rebased and fixed up following recent console changes

Peter Maydell (4):
  ui/cocoa.m: Fix leaks of NSScreen and NSConcreteMapTable
  ui/cocoa.m: Avoid deprecated CPS* functions
  ui/cocoa.m: Avoid deprecated NSOpenPanel filename method
  ui/cocoa.m: Avoid deprecated NSOpenPanel beginSheetForDirectory

 ui/cocoa.m | 52 ++++++++++++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 20 deletions(-)

-- 
1.7.11.4

             reply	other threads:[~2013-03-25 22:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 22:31 Peter Maydell [this message]
2013-03-25 22:31 ` [Qemu-devel] [PATCH v2 1/4] ui/cocoa.m: Fix leaks of NSScreen and NSConcreteMapTable Peter Maydell
2013-03-25 22:31 ` [Qemu-devel] [PATCH v2 2/4] ui/cocoa.m: Avoid deprecated CPS* functions Peter Maydell
2013-03-25 22:31 ` [Qemu-devel] [PATCH v2 3/4] ui/cocoa.m: Avoid deprecated NSOpenPanel filename method Peter Maydell
2013-03-25 22:31 ` [Qemu-devel] [PATCH v2 4/4] ui/cocoa.m: Avoid deprecated NSOpenPanel beginSheetForDirectory Peter Maydell
2013-04-06 22:39 ` [Qemu-devel] [PATCH v2 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364250694-7939-1-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=patches@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).