From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKFvY-0006g6-AV for qemu-devel@nongnu.org; Mon, 25 Mar 2013 18:31:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKFvV-00083Z-MJ for qemu-devel@nongnu.org; Mon, 25 Mar 2013 18:31:40 -0400 Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:1d0::1]:33202 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKFvV-00083N-GC for qemu-devel@nongnu.org; Mon, 25 Mar 2013 18:31:37 -0400 From: Peter Maydell Date: Mon, 25 Mar 2013 22:31:30 +0000 Message-Id: <1364250694-7939-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH v2 0/4] ui/cocoa.m: Fix compiler and runtime warnings on 10.8 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= , patches@linaro.org These patches fix various compiler and runtime warnings QEMU provokes on MacOSX 10.8. The first two fix a leak and some deprecated functions which cause warnings in the system log when QEMU runs. The second two avoid some functions which cause compile time warnings about use of functions deprecated in 10.6. I believe from my reading of the documentation that these changes should still work OK on 10.3, but I don't have any way of testing that. Andreas: I don't write much ObjC so I don't really have a feel for what is good coding style. I mostly tried to follow the existing code (eg "//" style comments) and QEMU's C style (eg 80 cols max). I'm happy to change any of the indentation or whatever to suit your preferences. With this patch set the only remaining compile time warnings from clang on 10.8 are about deprecated methods in audio/coreaudio.c. Changes v1->v2: * rebased and fixed up following recent console changes Peter Maydell (4): ui/cocoa.m: Fix leaks of NSScreen and NSConcreteMapTable ui/cocoa.m: Avoid deprecated CPS* functions ui/cocoa.m: Avoid deprecated NSOpenPanel filename method ui/cocoa.m: Avoid deprecated NSOpenPanel beginSheetForDirectory ui/cocoa.m | 52 ++++++++++++++++++++++++++++++++-------------------- 1 file changed, 32 insertions(+), 20 deletions(-) -- 1.7.11.4