* [Qemu-devel] [PATCH 0/2] Add TPM driver and ACPI support to SeaBIOS
@ 2013-03-26 14:14 Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 1/2] Add an implementation of a TPM TIS driver Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device Corey Bryant
0 siblings, 2 replies; 10+ messages in thread
From: Corey Bryant @ 2013-03-26 14:14 UTC (permalink / raw)
To: seabios; +Cc: Corey Bryant, qemu-devel, stefanb
The following set of patches is being resubmitted to add TPM support to
SeaBIOS. This series only includes a subset of the total seabios TPM
support that is planned. The patches included in this series provide
initial foundational support that make sense to include at this point
now that a passthrough vTPM is available in QEMU.
In particular, these patches add:
- a TPM driver for QEMU's TPM TIS emulation
- ACPI support for the TPM device (SSDT table)
- ACPI support for measurement logging (TCPA table)
Corey Bryant (2):
Add an implementation of a TPM TIS driver
Provide ACPI SSDT table for TPM device
Makefile | 9 ++-
src/acpi-tpm-ssdt.dsl | 24 +++++
src/acpi-tpm-ssdt.hex | 27 +++++
src/acpi.c | 41 ++++++++
src/acpi.h | 20 ++++
src/config.h | 2 +-
src/tcgbios.c | 70 +++++++++++++
src/tcgbios.h | 57 +++++++++++
src/tpm_drivers.c | 258 +++++++++++++++++++++++++++++++++++++++++++++++++
src/tpm_drivers.h | 90 +++++++++++++++++
10 files changed, 596 insertions(+), 2 deletions(-)
create mode 100644 src/acpi-tpm-ssdt.dsl
create mode 100644 src/acpi-tpm-ssdt.hex
create mode 100644 src/tcgbios.c
create mode 100644 src/tcgbios.h
create mode 100644 src/tpm_drivers.c
create mode 100644 src/tpm_drivers.h
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH 1/2] Add an implementation of a TPM TIS driver
2013-03-26 14:14 [Qemu-devel] [PATCH 0/2] Add TPM driver and ACPI support to SeaBIOS Corey Bryant
@ 2013-03-26 14:14 ` Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device Corey Bryant
1 sibling, 0 replies; 10+ messages in thread
From: Corey Bryant @ 2013-03-26 14:14 UTC (permalink / raw)
To: seabios; +Cc: Corey Bryant, qemu-devel, stefanb
This patch adds an implementation of a TPM TIS driver for the TPM TIS
emulation supported by QEMU (patches for passthrough vTPM are upstream in QEMU).
Usage of the driver is broken up into several functions. The driver is cleanly
separated from the rest of the code through an interface holding pointers to the
driver's functions. A client using this driver first probes whether the TPM TIS
interface is available (probe function) and then invokes the interface
functions to initialize the interface and send requests and receive responses.
Possible future extensions *could* include a virtio interface for the TPM
with a corresponding driver here.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
---
Version history from prior patch submission:
v7:
- moving declaration of tpm_drivers[] into tpm_drivers.h
v6:
- reworked timeouts; not hardcoded anymore
v5:
- introducing a configurable threashold as part of the driver interface
structure below which the TPM is used for calculating the sha1
v2:
- adapted tpm_drivers.c to be under LGPLv3
---
src/tpm_drivers.c | 258 +++++++++++++++++++++++++++++++++++++++++++++++++++++
src/tpm_drivers.h | 90 +++++++++++++++++++
2 files changed, 348 insertions(+), 0 deletions(-)
create mode 100644 src/tpm_drivers.c
create mode 100644 src/tpm_drivers.h
diff --git a/src/tpm_drivers.c b/src/tpm_drivers.c
new file mode 100644
index 0000000..edf192d
--- /dev/null
+++ b/src/tpm_drivers.c
@@ -0,0 +1,258 @@
+// Implementation of a TPM driver for the TPM TIS interface
+//
+// Copyright (C) 2006-2013 IBM Corporation
+//
+// Authors:
+// Stefan Berger <stefanb@linux.vnet.ibm.com>
+//
+// This file may be distributed under the terms of the GNU LGPLv3 license.
+
+#include "config.h"
+#include "util.h"
+#include "tpm_drivers.h"
+#include "tcgbios.h"
+
+static u32 tis_default_timeouts[4] = {
+ TIS_DEFAULT_TIMEOUT_A,
+ TIS_DEFAULT_TIMEOUT_B,
+ TIS_DEFAULT_TIMEOUT_C,
+ TIS_DEFAULT_TIMEOUT_D,
+};
+
+static u32 tpm_default_durations[3] = {
+ TPM_DEFAULT_DURATION_SHORT,
+ TPM_DEFAULT_DURATION_MEDIUM,
+ TPM_DEFAULT_DURATION_LONG,
+};
+
+
+/* if device is not there, return '0', '1' otherwise */
+static u32 tis_probe(void)
+{
+ u32 rc = 0;
+ u32 didvid = readl(TIS_REG(0, TIS_REG_DID_VID));
+
+ if ((didvid != 0) && (didvid != 0xffffffff))
+ rc = 1;
+
+ return rc;
+}
+
+static u32 tis_init(void)
+{
+ writeb(TIS_REG(0, TIS_REG_INT_ENABLE), 0);
+
+ if (tpm_drivers[TIS_DRIVER_IDX].durations == NULL) {
+ u32 *durations = malloc_low(sizeof(tpm_default_durations));
+ if (durations)
+ memcpy(durations, tpm_default_durations,
+ sizeof(tpm_default_durations));
+ else
+ durations = tpm_default_durations;
+ tpm_drivers[TIS_DRIVER_IDX].durations = durations;
+ }
+
+ if (tpm_drivers[TIS_DRIVER_IDX].timeouts == NULL) {
+ u32 *timeouts = malloc_low(sizeof(tis_default_timeouts));
+ if (timeouts)
+ memcpy(timeouts, tis_default_timeouts,
+ sizeof(tis_default_timeouts));
+ else
+ timeouts = tis_default_timeouts;
+ tpm_drivers[TIS_DRIVER_IDX].timeouts = timeouts;
+ }
+
+ return 1;
+}
+
+
+static void set_timeouts(u32 timeouts[4], u32 durations[3])
+{
+ u32 *tos = tpm_drivers[TIS_DRIVER_IDX].timeouts;
+ u32 *dus = tpm_drivers[TIS_DRIVER_IDX].durations;
+
+ if (tos && tos != tis_default_timeouts && timeouts)
+ memcpy(tos, timeouts, 4 * sizeof(u32));
+ if (dus && dus != tpm_default_durations && durations)
+ memcpy(dus, durations, 3 * sizeof(u32));
+}
+
+
+static u32 tis_wait_sts(u8 locty, u32 time, u8 mask, u8 expect)
+{
+ u32 rc = 1;
+
+ while (time > 0) {
+ u8 sts = readb(TIS_REG(locty, TIS_REG_STS));
+ if ((sts & mask) == expect) {
+ rc = 0;
+ break;
+ }
+ msleep(1);
+ time--;
+ }
+ return rc;
+}
+
+static u32 tis_activate(u8 locty)
+{
+ u32 rc = 0;
+ u8 acc;
+ int l;
+ u32 timeout_a = tpm_drivers[TIS_DRIVER_IDX].timeouts[TIS_TIMEOUT_TYPE_A];
+
+ if (!(readb(TIS_REG(locty, TIS_REG_ACCESS)) &
+ TIS_ACCESS_ACTIVE_LOCALITY)) {
+ /* release locality in use top-downwards */
+ for (l = 4; l >= 0; l--)
+ writeb(TIS_REG(l, TIS_REG_ACCESS),
+ TIS_ACCESS_ACTIVE_LOCALITY);
+ }
+
+ /* request access to locality */
+ writeb(TIS_REG(locty, TIS_REG_ACCESS), TIS_ACCESS_REQUEST_USE);
+
+ acc = readb(TIS_REG(locty, TIS_REG_ACCESS));
+ if ((acc & TIS_ACCESS_ACTIVE_LOCALITY)) {
+ writeb(TIS_REG(locty, TIS_REG_STS), TIS_STS_COMMAND_READY);
+ rc = tis_wait_sts(locty, timeout_a,
+ TIS_STS_COMMAND_READY, TIS_STS_COMMAND_READY);
+ }
+
+ return rc;
+}
+
+static u32 tis_find_active_locality(void)
+{
+ u8 locty;
+
+ for (locty = 0; locty <= 4; locty++) {
+ if ((readb(TIS_REG(locty, TIS_REG_ACCESS)) &
+ TIS_ACCESS_ACTIVE_LOCALITY))
+ return locty;
+ }
+
+ tis_activate(0);
+
+ return 0;
+}
+
+static u32 tis_ready(void)
+{
+ u32 rc = 0;
+ u8 locty = tis_find_active_locality();
+ u32 timeout_b = tpm_drivers[TIS_DRIVER_IDX].timeouts[TIS_TIMEOUT_TYPE_B];
+
+ writeb(TIS_REG(locty, TIS_REG_STS), TIS_STS_COMMAND_READY);
+ rc = tis_wait_sts(locty, timeout_b,
+ TIS_STS_COMMAND_READY, TIS_STS_COMMAND_READY);
+
+ return rc;
+}
+
+static u32 tis_senddata(const u8 *const data, u32 len)
+{
+ u32 rc = 0;
+ u32 offset = 0;
+ u32 end = 0;
+ u16 burst = 0;
+ u32 ctr = 0;
+ u8 locty = tis_find_active_locality();
+ u32 timeout_d = tpm_drivers[TIS_DRIVER_IDX].timeouts[TIS_TIMEOUT_TYPE_D];
+
+ do {
+ while (burst == 0 && ctr < timeout_d) {
+ burst = readl(TIS_REG(locty, TIS_REG_STS)) >> 8;
+ if (burst == 0) {
+ msleep(1);
+ ctr++;
+ }
+ }
+
+ if (burst == 0) {
+ rc = TCG_RESPONSE_TIMEOUT;
+ break;
+ }
+
+ while (1) {
+ writeb(TIS_REG(locty, TIS_REG_DATA_FIFO), data[offset++]);
+ burst--;
+
+ if (burst == 0 || offset == len)
+ break;
+ }
+
+ if (offset == len)
+ end = 1;
+ } while (end == 0);
+
+ return rc;
+}
+
+static u32 tis_readresp(u8 *buffer, u32 *len)
+{
+ u32 rc = 0;
+ u32 offset = 0;
+ u32 sts;
+ u8 locty = tis_find_active_locality();
+
+ while (offset < *len) {
+ buffer[offset] = readb(TIS_REG(locty, TIS_REG_DATA_FIFO));
+ offset++;
+ sts = readb(TIS_REG(locty, TIS_REG_STS));
+ /* data left ? */
+ if ((sts & TIS_STS_DATA_AVAILABLE) == 0)
+ break;
+ }
+
+ *len = offset;
+
+ return rc;
+}
+
+
+static u32 tis_waitdatavalid(void)
+{
+ u32 rc = 0;
+ u8 locty = tis_find_active_locality();
+ u32 timeout_c = tpm_drivers[TIS_DRIVER_IDX].timeouts[TIS_TIMEOUT_TYPE_C];
+
+ if (tis_wait_sts(locty, timeout_c, TIS_STS_VALID, TIS_STS_VALID) != 0)
+ rc = TCG_NO_RESPONSE;
+
+ return rc;
+}
+
+static u32 tis_waitrespready(enum tpmDurationType to_t)
+{
+ u32 rc = 0;
+ u8 locty = tis_find_active_locality();
+ u32 timeout = tpm_drivers[TIS_DRIVER_IDX].durations[to_t];
+
+ writeb(TIS_REG(locty ,TIS_REG_STS), TIS_STS_TPM_GO);
+
+ if (tis_wait_sts(locty, timeout,
+ TIS_STS_DATA_AVAILABLE, TIS_STS_DATA_AVAILABLE) != 0)
+ rc = TCG_NO_RESPONSE;
+
+ return rc;
+}
+
+
+struct tpm_driver tpm_drivers[TPM_NUM_DRIVERS] = {
+ [TIS_DRIVER_IDX] =
+ {
+ .timeouts = NULL,
+ .durations = NULL,
+ .set_timeouts = set_timeouts,
+ .probe = tis_probe,
+ .init = tis_init,
+ .activate = tis_activate,
+ .ready = tis_ready,
+ .senddata = tis_senddata,
+ .readresp = tis_readresp,
+ .waitdatavalid = tis_waitdatavalid,
+ .waitrespready = tis_waitrespready,
+ .sha1threshold = 100 * 1024,
+ },
+};
diff --git a/src/tpm_drivers.h b/src/tpm_drivers.h
new file mode 100644
index 0000000..34bb12d
--- /dev/null
+++ b/src/tpm_drivers.h
@@ -0,0 +1,90 @@
+#ifndef TPM_DRIVERS_H
+#define TPM_DRIVERS_H
+
+#include "types.h" // u32
+
+
+enum tpmDurationType {
+ TPM_DURATION_TYPE_SHORT = 0,
+ TPM_DURATION_TYPE_MEDIUM,
+ TPM_DURATION_TYPE_LONG,
+};
+
+/* low level driver implementation */
+struct tpm_driver {
+ u32 *timeouts;
+ u32 *durations;
+ void (*set_timeouts)(u32 timeouts[4], u32 durations[3]);
+ u32 (*probe)(void);
+ u32 (*init)(void);
+ u32 (*activate)(u8 locty);
+ u32 (*ready)(void);
+ u32 (*senddata)(const u8 *const data, u32 len);
+ u32 (*readresp)(u8 *buffer, u32 *len);
+ u32 (*waitdatavalid)(void);
+ u32 (*waitrespready)(enum tpmDurationType to_t);
+ /* the TPM will be used for buffers of sizes below the sha1threshold
+ for calculating the hash */
+ u32 sha1threshold;
+};
+
+extern struct tpm_driver tpm_drivers[];
+
+
+#define TIS_DRIVER_IDX 0
+#define TPM_NUM_DRIVERS 1
+
+#define TPM_INVALID_DRIVER -1
+
+/* TIS driver */
+/* address of locality 0 (TIS) */
+#define TPM_TIS_BASE_ADDRESS 0xfed40000
+
+#define TIS_REG(LOCTY, REG) \
+ (void *)(TPM_TIS_BASE_ADDRESS + (LOCTY << 12) + REG)
+
+/* hardware registers */
+#define TIS_REG_ACCESS 0x0
+#define TIS_REG_INT_ENABLE 0x8
+#define TIS_REG_INT_VECTOR 0xc
+#define TIS_REG_INT_STATUS 0x10
+#define TIS_REG_INTF_CAPABILITY 0x14
+#define TIS_REG_STS 0x18
+#define TIS_REG_DATA_FIFO 0x24
+#define TIS_REG_DID_VID 0xf00
+#define TIS_REG_RID 0xf04
+
+#define TIS_STS_VALID (1 << 7) /* 0x80 */
+#define TIS_STS_COMMAND_READY (1 << 6) /* 0x40 */
+#define TIS_STS_TPM_GO (1 << 5) /* 0x20 */
+#define TIS_STS_DATA_AVAILABLE (1 << 4) /* 0x10 */
+#define TIS_STS_EXPECT (1 << 3) /* 0x08 */
+#define TIS_STS_RESPONSE_RETRY (1 << 1) /* 0x02 */
+
+#define TIS_ACCESS_TPM_REG_VALID_STS (1 << 7) /* 0x80 */
+#define TIS_ACCESS_ACTIVE_LOCALITY (1 << 5) /* 0x20 */
+#define TIS_ACCESS_BEEN_SEIZED (1 << 4) /* 0x10 */
+#define TIS_ACCESS_SEIZE (1 << 3) /* 0x08 */
+#define TIS_ACCESS_PENDING_REQUEST (1 << 2) /* 0x04 */
+#define TIS_ACCESS_REQUEST_USE (1 << 1) /* 0x02 */
+#define TIS_ACCESS_TPM_ESTABLISHMENT (1 << 0) /* 0x01 */
+
+#define SCALER 10
+
+#define TIS_DEFAULT_TIMEOUT_A (750 * SCALER)
+#define TIS_DEFAULT_TIMEOUT_B (2000 * SCALER)
+#define TIS_DEFAULT_TIMEOUT_C (750 * SCALER)
+#define TIS_DEFAULT_TIMEOUT_D (750 * SCALER)
+
+enum tisTimeoutType {
+ TIS_TIMEOUT_TYPE_A = 0,
+ TIS_TIMEOUT_TYPE_B,
+ TIS_TIMEOUT_TYPE_C,
+ TIS_TIMEOUT_TYPE_D,
+};
+
+#define TPM_DEFAULT_DURATION_SHORT (2000 * SCALER)
+#define TPM_DEFAULT_DURATION_MEDIUM (20000 * SCALER)
+#define TPM_DEFAULT_DURATION_LONG (60000 * SCALER)
+
+#endif /* TPM_DRIVERS_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-03-26 14:14 [Qemu-devel] [PATCH 0/2] Add TPM driver and ACPI support to SeaBIOS Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 1/2] Add an implementation of a TPM TIS driver Corey Bryant
@ 2013-03-26 14:14 ` Corey Bryant
2013-03-28 9:03 ` Paolo Bonzini
1 sibling, 1 reply; 10+ messages in thread
From: Corey Bryant @ 2013-03-26 14:14 UTC (permalink / raw)
To: seabios; +Cc: Corey Bryant, qemu-devel, stefanb
This patch provides ACPI support for the TPM device. It probes for the TPM
device and only if a TPM device is found then the TPM's SSDT and TCPA table
are created. This patch also connects them to the RSDT.
Since the logging area in the TCPA table requires 64kb, the memory reserved
for ACPI tables (config.h) is increased to 96kb.
The IRQ description in the TPM's SSDT is commented since it will be
'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example
has too many issues when run in interrupt mode.
The description of the TCPA (client) table can be found here:
http://www.trustedcomputinggroup.org/resources/server_work_group_acpi_general_specification_version_10
The compiled SSDT description is also part of this patch.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
---
Version history from prior patch submission:
v6:
- following Andreas Niederl's suggestion: enclosing Device(TPM) in
Scope(\_SB) { ... } to have Linux 2.6.33 recognize the device properly;
seems to work fine with 3.0.0
v2:
- Increasing the CONFIG_MAX_HIGHTABLE to 96kb
- Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
- Build tpm_drivers.c and tcgbios.c
-> TPM's SSDT and TCPA tables are now visible in Linux
---
Makefile | 9 +++++-
src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++
src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++
src/acpi.c | 41 ++++++++++++++++++++++++++++
src/acpi.h | 20 ++++++++++++++
src/config.h | 2 +-
src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++
src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++
8 files changed, 248 insertions(+), 2 deletions(-)
create mode 100644 src/acpi-tpm-ssdt.dsl
create mode 100644 src/acpi-tpm-ssdt.hex
create mode 100644 src/tcgbios.c
create mode 100644 src/tcgbios.h
diff --git a/Makefile b/Makefile
index 759bbbb..2807010 100644
--- a/Makefile
+++ b/Makefile
@@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c
SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \
acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \
lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \
- biostables.c xen.c bmp.c romfile.c csm.c
+ biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c
SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c
# Default compiler flags
@@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py
iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
; then echo "$(2)"; else echo "$(3)"; fi ;)
+src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl
+ @echo "Compiling TPM SSDT"
+ $(Q)cpp -P $< > $(OUT)$*.dsl.i
+ $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i
+ $(Q)cp $(OUT)$*.hex $@
+ $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@
+
$(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py
@echo " Compiling IASL $@"
$(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.orig
diff --git a/src/acpi-tpm-ssdt.dsl b/src/acpi-tpm-ssdt.dsl
new file mode 100644
index 0000000..080bae4
--- /dev/null
+++ b/src/acpi-tpm-ssdt.dsl
@@ -0,0 +1,24 @@
+DefinitionBlock (
+ "acpi-tpm-ssdt.aml",// Output Filename
+ "SSDT", // Signature
+ 0x01, // SSDT Compliance Revision
+ "BXPC", // OEMID
+ "BXSSDT", // TABLE ID
+ 0x1 // OEM Revision
+ )
+{
+ Scope(\_SB) {
+ /* TPM with emulated TPM TIS interface */
+ Device (TPM) {
+ Name (_HID, EisaID ("PNP0C31"))
+ Name (_CRS, ResourceTemplate ()
+ {
+ Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000)
+ //IRQNoFlags () {5}
+ })
+ Method (_STA, 0, NotSerialized) {
+ Return (0x0F)
+ }
+ }
+ }
+}
diff --git a/src/acpi-tpm-ssdt.hex b/src/acpi-tpm-ssdt.hex
new file mode 100644
index 0000000..acbb78f
--- /dev/null
+++ b/src/acpi-tpm-ssdt.hex
@@ -0,0 +1,27 @@
+/*
+ *
+ * Intel ACPI Component Architecture
+ * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010]
+ * Copyright (c) 2000 - 2010 Intel Corporation
+ *
+ * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012
+ *
+ * C source code output
+ * AML code block contains 0x5D bytes
+ *
+ */
+unsigned char AmlCode_TPM[] =
+{
+ 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */
+ 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */
+ 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */
+ 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */
+ 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */
+ 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */
+ 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */
+ 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */
+ 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */
+ 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */
+ 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */
+ 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */
+};
diff --git a/src/acpi.c b/src/acpi.c
index bc4d8ea..86c9770 100644
--- a/src/acpi.c
+++ b/src/acpi.c
@@ -15,6 +15,8 @@
#include "config.h" // CONFIG_*
#include "paravirt.h" // RamSize
#include "dev-q35.h"
+#include "acpi-tpm-ssdt.hex"
+#include "tcgbios.h" // has_working_tpm
/****************************************************/
/* ACPI tables init */
@@ -762,6 +764,39 @@ static const struct pci_device_id acpi_find_tbl[] = {
PCI_DEVICE_END,
};
+
+static u32 add_tpm_device(void **tpm_addr, void **tcpa_addr)
+{
+ struct tcpa_descriptor_rev2 *tcpa;
+
+ *tpm_addr = NULL;
+ *tcpa_addr = NULL;
+
+ if (has_working_tpm()) {
+ u32 laml = 64 * 1024;
+ *tpm_addr = malloc_high(sizeof(AmlCode_TPM));
+
+ tcpa = malloc_high(sizeof(*tcpa) + laml);
+ if (!tcpa || !*tpm_addr) {
+ warn_noalloc();
+ return 1;
+ }
+
+ if (*tpm_addr)
+ memcpy(*tpm_addr, AmlCode_TPM, sizeof(AmlCode_TPM));
+
+ memset(tcpa, 0x0, sizeof(*tcpa) + laml);
+ u64 lasa = (u32)tcpa + sizeof(*tcpa);
+
+ tcpa->laml = laml;
+ tcpa->lasa = lasa;
+ build_header((void*)tcpa, TCPA_SIGNATURE, sizeof(*tcpa), 2);
+
+ *tcpa_addr = tcpa;
+ }
+ return 0;
+}
+
struct rsdp_descriptor *RsdpAddr;
#define MAX_ACPI_TABLES 20
@@ -835,6 +870,12 @@ acpi_setup(void)
fill_dsdt(fadt, dsdt);
}
+ void *tcpa, *tpm;
+ if (add_tpm_device(&tpm, &tcpa))
+ return;
+ ACPI_INIT_TABLE(tpm);
+ ACPI_INIT_TABLE(tcpa);
+
// Build final rsdt table
struct rsdt_descriptor_rev1 *rsdt;
size_t rsdt_len = sizeof(*rsdt) + sizeof(u32) * tbl_idx;
diff --git a/src/acpi.h b/src/acpi.h
index 7fbd082..c2c778c 100644
--- a/src/acpi.h
+++ b/src/acpi.h
@@ -130,4 +130,24 @@ struct acpi_table_mcfg {
struct acpi_mcfg_allocation allocation[0];
} PACKED;
+
+struct rsdt_descriptor {
+ ACPI_TABLE_HEADER_DEF
+ u32 entry[1];
+} PACKED;
+
+#define TCPA_SIGNATURE 0x41504354
+struct tcpa_descriptor_rev2
+{
+ ACPI_TABLE_HEADER_DEF
+ u16 platform_class;
+ u32 laml;
+ u64 lasa;
+} PACKED;
+
+/* TCPA ACPI definitions */
+#define TCPA_ACPI_CLASS_CLIENT 0
+#define TCPA_ACPI_CLASS_SERVER 1
+
+
#endif // acpi.h
diff --git a/src/config.h b/src/config.h
index 64e3c92..3d66568 100644
--- a/src/config.h
+++ b/src/config.h
@@ -17,7 +17,7 @@
// Maximum number of map entries in the e820 map
#define BUILD_MAX_E820 32
// Space to reserve in high-memory for tables
-#define BUILD_MAX_HIGHTABLE (64*1024)
+#define BUILD_MAX_HIGHTABLE (96*1024)
// Largest supported externaly facing drive id
#define BUILD_MAX_EXTDRIVE 16
// Number of bytes the smbios may be and still live in the f-segment
diff --git a/src/tcgbios.c b/src/tcgbios.c
new file mode 100644
index 0000000..f593a5f
--- /dev/null
+++ b/src/tcgbios.c
@@ -0,0 +1,70 @@
+// Implementation of the TCG BIOS extension according to the specification
+// described in
+// https://www.trustedcomputinggroup.org/specs/PCClient/TCG_PCClientImplementationforBIOS_1-20_1-00.pdf
+//
+// Copyright (C) 2006-2013 IBM Corporation
+//
+// Authors:
+// Stefan Berger <stefanb@linux.vnet.ibm.com>
+//
+// This file may be distributed under the terms of the GNU LGPLv3 license.
+
+
+#include "config.h"
+
+#include "types.h"
+#include "tpm_drivers.h" // tpm_drivers[]
+
+
+typedef struct {
+ u8 tpm_probed:1;
+ u8 tpm_found:1;
+ u8 tpm_working:1;
+ u8 if_shutdown:1;
+ u8 tpm_driver_to_use:4;
+} tcpa_state_t;
+
+
+static tcpa_state_t tcpa_state = {
+ .tpm_driver_to_use = TPM_INVALID_DRIVER,
+};
+
+
+/********************************************************
+ Extensions for TCG-enabled BIOS
+ *******************************************************/
+
+
+static u32
+is_tpm_present(void)
+{
+ u32 rc = 0;
+ unsigned int i;
+
+ for (i = 0; i < TPM_NUM_DRIVERS; i++) {
+ struct tpm_driver *td = &tpm_drivers[i];
+ if (td->probe() != 0) {
+ td->init();
+ tcpa_state.tpm_driver_to_use = i;
+ rc = 1;
+ break;
+ }
+ }
+
+ return rc;
+}
+
+
+int
+has_working_tpm(void)
+{
+ if (!tcpa_state.tpm_probed) {
+ tcpa_state.tpm_probed = 1;
+ tcpa_state.tpm_found = (is_tpm_present() != 0);
+ tcpa_state.tpm_working = 1;
+ }
+ if (!tcpa_state.tpm_working)
+ return 0;
+
+ return tcpa_state.tpm_found;
+}
diff --git a/src/tcgbios.h b/src/tcgbios.h
new file mode 100644
index 0000000..b6023fe
--- /dev/null
+++ b/src/tcgbios.h
@@ -0,0 +1,57 @@
+#ifndef TCGBIOS_H
+#define TCGBIOS_H
+
+
+#define TPM_OK 0x0
+#define TPM_RET_BASE 0x1
+#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0)
+#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1)
+#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2)
+#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3)
+#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4)
+#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5)
+#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6)
+#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7)
+#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8)
+#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9)
+#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa)
+#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb)
+#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc)
+#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd)
+#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe)
+#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf)
+#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10)
+#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11)
+#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12)
+#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13)
+#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14)
+#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15)
+#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16)
+#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17)
+#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18)
+#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19)
+#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20)
+//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21)
+#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22)
+#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23)
+
+
+#define TPM_INVALID_ADR_REQUEST TCG_INVALID_ADR_REQUEST
+#define TPM_IS_LOCKED TCG_TPM_IS_LOCKED
+#define TPM_INVALID_DEVICE_ID TCG_INVALID_DEVICE_ID
+#define TPM_INVALID_VENDOR_ID TCG_INVALID_VENDOR_ID
+//define TPM_RESERVED_REG_INVALID
+#define TPM_FIRMWARE_ERROR TCG_FIRMWARE_ERROR
+#define TPM_UNABLE_TO_OPEN TCG_UNABLE_TO_OPEN
+#define TPM_UNABLE_TO_CLOSE TCG_UNABLE_TO_CLOSE
+#define TPM_INVALID_RESPONSE TCG_INVALID_RESPONSE
+#define TPM_RESPONSE_TIMEOUT TCG_RESPONSE_TIMEOUT
+#define TPM_INVALID_ACCESS_REQUEST TCG_INVALID_ACCESS_REQUEST
+#define TPM_TRANSFER_ABORT TCG_TRANSFER_ABORT
+#define TPM_GENERAL_ERROR TCG_GENERAL_ERROR
+
+
+int has_working_tpm(void);
+
+
+#endif /* TCGBIOS_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-03-26 14:14 ` [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device Corey Bryant
@ 2013-03-28 9:03 ` Paolo Bonzini
2013-04-01 19:05 ` Corey Bryant
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Bonzini @ 2013-03-28 9:03 UTC (permalink / raw)
To: Corey Bryant
Cc: Laszlo Ersek, seabios, Michael S. Tsirkin, qemu-devel, stefanb
Il 26/03/2013 15:14, Corey Bryant ha scritto:
> This patch provides ACPI support for the TPM device. It probes for the TPM
> device and only if a TPM device is found then the TPM's SSDT and TCPA table
> are created. This patch also connects them to the RSDT.
>
> Since the logging area in the TCPA table requires 64kb, the memory reserved
> for ACPI tables (config.h) is increased to 96kb.
>
> The IRQ description in the TPM's SSDT is commented since it will be
> 'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example
> has too many issues when run in interrupt mode.
>
> The description of the TCPA (client) table can be found here:
>
> http://www.trustedcomputinggroup.org/resources/server_work_group_acpi_general_specification_version_10
>
> The compiled SSDT description is also part of this patch.
There is work on moving ACPI tables to QEMU. Please work with the other
developers (Kevin of course, and Michael and Laszlo who I have CCed) on
this.
Paolo
> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> Version history from prior patch submission:
>
> v6:
> - following Andreas Niederl's suggestion: enclosing Device(TPM) in
> Scope(\_SB) { ... } to have Linux 2.6.33 recognize the device properly;
> seems to work fine with 3.0.0
>
> v2:
> - Increasing the CONFIG_MAX_HIGHTABLE to 96kb
> - Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
> - Build tpm_drivers.c and tcgbios.c
> -> TPM's SSDT and TCPA tables are now visible in Linux
> ---
> Makefile | 9 +++++-
> src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++
> src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++
> src/acpi.c | 41 ++++++++++++++++++++++++++++
> src/acpi.h | 20 ++++++++++++++
> src/config.h | 2 +-
> src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++
> src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++
> 8 files changed, 248 insertions(+), 2 deletions(-)
> create mode 100644 src/acpi-tpm-ssdt.dsl
> create mode 100644 src/acpi-tpm-ssdt.hex
> create mode 100644 src/tcgbios.c
> create mode 100644 src/tcgbios.h
>
> diff --git a/Makefile b/Makefile
> index 759bbbb..2807010 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c
> SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \
> acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \
> lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \
> - biostables.c xen.c bmp.c romfile.c csm.c
> + biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c
> SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c
>
> # Default compiler flags
> @@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py
> iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
> ; then echo "$(2)"; else echo "$(3)"; fi ;)
>
> +src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl
> + @echo "Compiling TPM SSDT"
> + $(Q)cpp -P $< > $(OUT)$*.dsl.i
> + $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i
> + $(Q)cp $(OUT)$*.hex $@
> + $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@
> +
> $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py
> @echo " Compiling IASL $@"
> $(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.orig
> diff --git a/src/acpi-tpm-ssdt.dsl b/src/acpi-tpm-ssdt.dsl
> new file mode 100644
> index 0000000..080bae4
> --- /dev/null
> +++ b/src/acpi-tpm-ssdt.dsl
> @@ -0,0 +1,24 @@
> +DefinitionBlock (
> + "acpi-tpm-ssdt.aml",// Output Filename
> + "SSDT", // Signature
> + 0x01, // SSDT Compliance Revision
> + "BXPC", // OEMID
> + "BXSSDT", // TABLE ID
> + 0x1 // OEM Revision
> + )
> +{
> + Scope(\_SB) {
> + /* TPM with emulated TPM TIS interface */
> + Device (TPM) {
> + Name (_HID, EisaID ("PNP0C31"))
> + Name (_CRS, ResourceTemplate ()
> + {
> + Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000)
> + //IRQNoFlags () {5}
> + })
> + Method (_STA, 0, NotSerialized) {
> + Return (0x0F)
> + }
> + }
> + }
> +}
> diff --git a/src/acpi-tpm-ssdt.hex b/src/acpi-tpm-ssdt.hex
> new file mode 100644
> index 0000000..acbb78f
> --- /dev/null
> +++ b/src/acpi-tpm-ssdt.hex
> @@ -0,0 +1,27 @@
> +/*
> + *
> + * Intel ACPI Component Architecture
> + * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010]
> + * Copyright (c) 2000 - 2010 Intel Corporation
> + *
> + * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012
> + *
> + * C source code output
> + * AML code block contains 0x5D bytes
> + *
> + */
> +unsigned char AmlCode_TPM[] =
> +{
> + 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */
> + 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */
> + 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */
> + 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */
> + 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */
> + 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */
> + 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */
> + 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */
> + 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */
> + 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */
> + 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */
> + 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */
> +};
> diff --git a/src/acpi.c b/src/acpi.c
> index bc4d8ea..86c9770 100644
> --- a/src/acpi.c
> +++ b/src/acpi.c
> @@ -15,6 +15,8 @@
> #include "config.h" // CONFIG_*
> #include "paravirt.h" // RamSize
> #include "dev-q35.h"
> +#include "acpi-tpm-ssdt.hex"
> +#include "tcgbios.h" // has_working_tpm
>
> /****************************************************/
> /* ACPI tables init */
> @@ -762,6 +764,39 @@ static const struct pci_device_id acpi_find_tbl[] = {
> PCI_DEVICE_END,
> };
>
> +
> +static u32 add_tpm_device(void **tpm_addr, void **tcpa_addr)
> +{
> + struct tcpa_descriptor_rev2 *tcpa;
> +
> + *tpm_addr = NULL;
> + *tcpa_addr = NULL;
> +
> + if (has_working_tpm()) {
> + u32 laml = 64 * 1024;
> + *tpm_addr = malloc_high(sizeof(AmlCode_TPM));
> +
> + tcpa = malloc_high(sizeof(*tcpa) + laml);
> + if (!tcpa || !*tpm_addr) {
> + warn_noalloc();
> + return 1;
> + }
> +
> + if (*tpm_addr)
> + memcpy(*tpm_addr, AmlCode_TPM, sizeof(AmlCode_TPM));
> +
> + memset(tcpa, 0x0, sizeof(*tcpa) + laml);
> + u64 lasa = (u32)tcpa + sizeof(*tcpa);
> +
> + tcpa->laml = laml;
> + tcpa->lasa = lasa;
> + build_header((void*)tcpa, TCPA_SIGNATURE, sizeof(*tcpa), 2);
> +
> + *tcpa_addr = tcpa;
> + }
> + return 0;
> +}
> +
> struct rsdp_descriptor *RsdpAddr;
>
> #define MAX_ACPI_TABLES 20
> @@ -835,6 +870,12 @@ acpi_setup(void)
> fill_dsdt(fadt, dsdt);
> }
>
> + void *tcpa, *tpm;
> + if (add_tpm_device(&tpm, &tcpa))
> + return;
> + ACPI_INIT_TABLE(tpm);
> + ACPI_INIT_TABLE(tcpa);
> +
> // Build final rsdt table
> struct rsdt_descriptor_rev1 *rsdt;
> size_t rsdt_len = sizeof(*rsdt) + sizeof(u32) * tbl_idx;
> diff --git a/src/acpi.h b/src/acpi.h
> index 7fbd082..c2c778c 100644
> --- a/src/acpi.h
> +++ b/src/acpi.h
> @@ -130,4 +130,24 @@ struct acpi_table_mcfg {
> struct acpi_mcfg_allocation allocation[0];
> } PACKED;
>
> +
> +struct rsdt_descriptor {
> + ACPI_TABLE_HEADER_DEF
> + u32 entry[1];
> +} PACKED;
> +
> +#define TCPA_SIGNATURE 0x41504354
> +struct tcpa_descriptor_rev2
> +{
> + ACPI_TABLE_HEADER_DEF
> + u16 platform_class;
> + u32 laml;
> + u64 lasa;
> +} PACKED;
> +
> +/* TCPA ACPI definitions */
> +#define TCPA_ACPI_CLASS_CLIENT 0
> +#define TCPA_ACPI_CLASS_SERVER 1
> +
> +
> #endif // acpi.h
> diff --git a/src/config.h b/src/config.h
> index 64e3c92..3d66568 100644
> --- a/src/config.h
> +++ b/src/config.h
> @@ -17,7 +17,7 @@
> // Maximum number of map entries in the e820 map
> #define BUILD_MAX_E820 32
> // Space to reserve in high-memory for tables
> -#define BUILD_MAX_HIGHTABLE (64*1024)
> +#define BUILD_MAX_HIGHTABLE (96*1024)
> // Largest supported externaly facing drive id
> #define BUILD_MAX_EXTDRIVE 16
> // Number of bytes the smbios may be and still live in the f-segment
> diff --git a/src/tcgbios.c b/src/tcgbios.c
> new file mode 100644
> index 0000000..f593a5f
> --- /dev/null
> +++ b/src/tcgbios.c
> @@ -0,0 +1,70 @@
> +// Implementation of the TCG BIOS extension according to the specification
> +// described in
> +// https://www.trustedcomputinggroup.org/specs/PCClient/TCG_PCClientImplementationforBIOS_1-20_1-00.pdf
> +//
> +// Copyright (C) 2006-2013 IBM Corporation
> +//
> +// Authors:
> +// Stefan Berger <stefanb@linux.vnet.ibm.com>
> +//
> +// This file may be distributed under the terms of the GNU LGPLv3 license.
> +
> +
> +#include "config.h"
> +
> +#include "types.h"
> +#include "tpm_drivers.h" // tpm_drivers[]
> +
> +
> +typedef struct {
> + u8 tpm_probed:1;
> + u8 tpm_found:1;
> + u8 tpm_working:1;
> + u8 if_shutdown:1;
> + u8 tpm_driver_to_use:4;
> +} tcpa_state_t;
> +
> +
> +static tcpa_state_t tcpa_state = {
> + .tpm_driver_to_use = TPM_INVALID_DRIVER,
> +};
> +
> +
> +/********************************************************
> + Extensions for TCG-enabled BIOS
> + *******************************************************/
> +
> +
> +static u32
> +is_tpm_present(void)
> +{
> + u32 rc = 0;
> + unsigned int i;
> +
> + for (i = 0; i < TPM_NUM_DRIVERS; i++) {
> + struct tpm_driver *td = &tpm_drivers[i];
> + if (td->probe() != 0) {
> + td->init();
> + tcpa_state.tpm_driver_to_use = i;
> + rc = 1;
> + break;
> + }
> + }
> +
> + return rc;
> +}
> +
> +
> +int
> +has_working_tpm(void)
> +{
> + if (!tcpa_state.tpm_probed) {
> + tcpa_state.tpm_probed = 1;
> + tcpa_state.tpm_found = (is_tpm_present() != 0);
> + tcpa_state.tpm_working = 1;
> + }
> + if (!tcpa_state.tpm_working)
> + return 0;
> +
> + return tcpa_state.tpm_found;
> +}
> diff --git a/src/tcgbios.h b/src/tcgbios.h
> new file mode 100644
> index 0000000..b6023fe
> --- /dev/null
> +++ b/src/tcgbios.h
> @@ -0,0 +1,57 @@
> +#ifndef TCGBIOS_H
> +#define TCGBIOS_H
> +
> +
> +#define TPM_OK 0x0
> +#define TPM_RET_BASE 0x1
> +#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0)
> +#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1)
> +#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2)
> +#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3)
> +#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4)
> +#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5)
> +#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6)
> +#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7)
> +#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8)
> +#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9)
> +#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa)
> +#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb)
> +#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc)
> +#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd)
> +#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe)
> +#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf)
> +#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10)
> +#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11)
> +#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12)
> +#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13)
> +#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14)
> +#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15)
> +#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16)
> +#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17)
> +#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18)
> +#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19)
> +#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20)
> +//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21)
> +#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22)
> +#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23)
> +
> +
> +#define TPM_INVALID_ADR_REQUEST TCG_INVALID_ADR_REQUEST
> +#define TPM_IS_LOCKED TCG_TPM_IS_LOCKED
> +#define TPM_INVALID_DEVICE_ID TCG_INVALID_DEVICE_ID
> +#define TPM_INVALID_VENDOR_ID TCG_INVALID_VENDOR_ID
> +//define TPM_RESERVED_REG_INVALID
> +#define TPM_FIRMWARE_ERROR TCG_FIRMWARE_ERROR
> +#define TPM_UNABLE_TO_OPEN TCG_UNABLE_TO_OPEN
> +#define TPM_UNABLE_TO_CLOSE TCG_UNABLE_TO_CLOSE
> +#define TPM_INVALID_RESPONSE TCG_INVALID_RESPONSE
> +#define TPM_RESPONSE_TIMEOUT TCG_RESPONSE_TIMEOUT
> +#define TPM_INVALID_ACCESS_REQUEST TCG_INVALID_ACCESS_REQUEST
> +#define TPM_TRANSFER_ABORT TCG_TRANSFER_ABORT
> +#define TPM_GENERAL_ERROR TCG_GENERAL_ERROR
> +
> +
> +int has_working_tpm(void);
> +
> +
> +#endif /* TCGBIOS_H */
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-03-28 9:03 ` Paolo Bonzini
@ 2013-04-01 19:05 ` Corey Bryant
2013-04-02 0:11 ` Kevin O'Connor
0 siblings, 1 reply; 10+ messages in thread
From: Corey Bryant @ 2013-04-01 19:05 UTC (permalink / raw)
To: kevin; +Cc: Paolo Bonzini, Michael S. Tsirkin, Laszlo Ersek, qemu-devel,
stefanb
On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
> Il 26/03/2013 15:14, Corey Bryant ha scritto:
>> This patch provides ACPI support for the TPM device. It probes for the TPM
>> device and only if a TPM device is found then the TPM's SSDT and TCPA table
>> are created. This patch also connects them to the RSDT.
>>
>> Since the logging area in the TCPA table requires 64kb, the memory reserved
>> for ACPI tables (config.h) is increased to 96kb.
>>
>> The IRQ description in the TPM's SSDT is commented since it will be
>> 'safer' to run the TPM in polling mode - the Linux TPM TIS driver for example
>> has too many issues when run in interrupt mode.
>>
>> The description of the TCPA (client) table can be found here:
>>
>> http://www.trustedcomputinggroup.org/resources/server_work_group_acpi_general_specification_version_10
>>
>> The compiled SSDT description is also part of this patch.
>
> There is work on moving ACPI tables to QEMU. Please work with the other
> developers (Kevin of course, and Michael and Laszlo who I have CCed) on
> this.
>
> Paolo
>
Kevin, Do you have a preference whether we add these ACPI tables to
SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
SeaBIOS and this adds probably 200 bytes of code and data. Basically it
creates the TPM's SSDT and TCPA (for logging) and connects them to the RSDT.
--
Regards,
Corey Bryant
>> Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
>> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
>> ---
>> Version history from prior patch submission:
>>
>> v6:
>> - following Andreas Niederl's suggestion: enclosing Device(TPM) in
>> Scope(\_SB) { ... } to have Linux 2.6.33 recognize the device properly;
>> seems to work fine with 3.0.0
>>
>> v2:
>> - Increasing the CONFIG_MAX_HIGHTABLE to 96kb
>> - Adding cut-down tcgbios.c|h to keep SeaBIOS compiling
>> - Build tpm_drivers.c and tcgbios.c
>> -> TPM's SSDT and TCPA tables are now visible in Linux
>> ---
>> Makefile | 9 +++++-
>> src/acpi-tpm-ssdt.dsl | 24 +++++++++++++++++
>> src/acpi-tpm-ssdt.hex | 27 +++++++++++++++++++
>> src/acpi.c | 41 ++++++++++++++++++++++++++++
>> src/acpi.h | 20 ++++++++++++++
>> src/config.h | 2 +-
>> src/tcgbios.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++++
>> src/tcgbios.h | 57 +++++++++++++++++++++++++++++++++++++++
>> 8 files changed, 248 insertions(+), 2 deletions(-)
>> create mode 100644 src/acpi-tpm-ssdt.dsl
>> create mode 100644 src/acpi-tpm-ssdt.hex
>> create mode 100644 src/tcgbios.c
>> create mode 100644 src/tcgbios.h
>>
>> diff --git a/Makefile b/Makefile
>> index 759bbbb..2807010 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -18,7 +18,7 @@ SRC16=$(SRCBOTH) system.c disk.c font.c
>> SRC32FLAT=$(SRCBOTH) post.c shadow.c memmap.c pmm.c coreboot.c boot.c \
>> acpi.c smm.c mptable.c pirtable.c smbios.c pciinit.c optionroms.c mtrr.c \
>> lzmadecode.c bootsplash.c jpeg.c usb-hub.c paravirt.c \
>> - biostables.c xen.c bmp.c romfile.c csm.c
>> + biostables.c xen.c bmp.c romfile.c csm.c tcgbios.c tpm_drivers.c
>> SRC32SEG=util.c output.c pci.c pcibios.c apm.c stacks.c
>>
>> # Default compiler flags
>> @@ -215,6 +215,13 @@ $(OUT)vgabios.bin: $(OUT)vgabios.bin.raw tools/buildrom.py
>> iasl-option=$(shell if test -z "`$(1) $(2) 2>&1 > /dev/null`" \
>> ; then echo "$(2)"; else echo "$(3)"; fi ;)
>>
>> +src/acpi-tpm-ssdt.hex: src/acpi-tpm-ssdt.dsl
>> + @echo "Compiling TPM SSDT"
>> + $(Q)cpp -P $< > $(OUT)$*.dsl.i
>> + $(Q)iasl -tc -p $(OUT)$* $(OUT)$*.dsl.i
>> + $(Q)cp $(OUT)$*.hex $@
>> + $(Q)sed -i 's/AmlCode/AmlCode_TPM/' $@
>> +
>> $(OUT)%.hex: src/%.dsl ./tools/acpi_extract_preprocess.py ./tools/acpi_extract.py
>> @echo " Compiling IASL $@"
>> $(Q)$(CPP) $(CPPFLAGS) $< -o $(OUT)$*.dsl.i.orig
>> diff --git a/src/acpi-tpm-ssdt.dsl b/src/acpi-tpm-ssdt.dsl
>> new file mode 100644
>> index 0000000..080bae4
>> --- /dev/null
>> +++ b/src/acpi-tpm-ssdt.dsl
>> @@ -0,0 +1,24 @@
>> +DefinitionBlock (
>> + "acpi-tpm-ssdt.aml",// Output Filename
>> + "SSDT", // Signature
>> + 0x01, // SSDT Compliance Revision
>> + "BXPC", // OEMID
>> + "BXSSDT", // TABLE ID
>> + 0x1 // OEM Revision
>> + )
>> +{
>> + Scope(\_SB) {
>> + /* TPM with emulated TPM TIS interface */
>> + Device (TPM) {
>> + Name (_HID, EisaID ("PNP0C31"))
>> + Name (_CRS, ResourceTemplate ()
>> + {
>> + Memory32Fixed (ReadWrite, 0xFED40000, 0x00005000)
>> + //IRQNoFlags () {5}
>> + })
>> + Method (_STA, 0, NotSerialized) {
>> + Return (0x0F)
>> + }
>> + }
>> + }
>> +}
>> diff --git a/src/acpi-tpm-ssdt.hex b/src/acpi-tpm-ssdt.hex
>> new file mode 100644
>> index 0000000..acbb78f
>> --- /dev/null
>> +++ b/src/acpi-tpm-ssdt.hex
>> @@ -0,0 +1,27 @@
>> +/*
>> + *
>> + * Intel ACPI Component Architecture
>> + * ASL Optimizing Compiler version 20101013-64 [Nov 21 2010]
>> + * Copyright (c) 2000 - 2010 Intel Corporation
>> + *
>> + * Compilation of "out/.dsl.i" - Mon Jan 30 16:03:18 2012
>> + *
>> + * C source code output
>> + * AML code block contains 0x5D bytes
>> + *
>> + */
>> +unsigned char AmlCode_TPM[] =
>> +{
>> + 0x53,0x53,0x44,0x54,0x5D,0x00,0x00,0x00, /* 00000000 "SSDT]..." */
>> + 0x01,0x15,0x42,0x58,0x50,0x43,0x00,0x00, /* 00000008 "..BXPC.." */
>> + 0x42,0x58,0x53,0x53,0x44,0x54,0x00,0x00, /* 00000010 "BXSSDT.." */
>> + 0x01,0x00,0x00,0x00,0x49,0x4E,0x54,0x4C, /* 00000018 "....INTL" */
>> + 0x13,0x10,0x10,0x20,0x10,0x38,0x5C,0x5F, /* 00000020 "... .8\_" */
>> + 0x53,0x42,0x5F,0x5B,0x82,0x30,0x54,0x50, /* 00000028 "SB_[.0TP" */
>> + 0x4D,0x5F,0x08,0x5F,0x48,0x49,0x44,0x0C, /* 00000030 "M_._HID." */
>> + 0x41,0xD0,0x0C,0x31,0x08,0x5F,0x43,0x52, /* 00000038 "A..1._CR" */
>> + 0x53,0x11,0x11,0x0A,0x0E,0x86,0x09,0x00, /* 00000040 "S......." */
>> + 0x01,0x00,0x00,0xD4,0xFE,0x00,0x50,0x00, /* 00000048 "......P." */
>> + 0x00,0x79,0x00,0x14,0x09,0x5F,0x53,0x54, /* 00000050 ".y..._ST" */
>> + 0x41,0x00,0xA4,0x0A,0x0F /* 00000058 "A...." */
>> +};
>> diff --git a/src/acpi.c b/src/acpi.c
>> index bc4d8ea..86c9770 100644
>> --- a/src/acpi.c
>> +++ b/src/acpi.c
>> @@ -15,6 +15,8 @@
>> #include "config.h" // CONFIG_*
>> #include "paravirt.h" // RamSize
>> #include "dev-q35.h"
>> +#include "acpi-tpm-ssdt.hex"
>> +#include "tcgbios.h" // has_working_tpm
>>
>> /****************************************************/
>> /* ACPI tables init */
>> @@ -762,6 +764,39 @@ static const struct pci_device_id acpi_find_tbl[] = {
>> PCI_DEVICE_END,
>> };
>>
>> +
>> +static u32 add_tpm_device(void **tpm_addr, void **tcpa_addr)
>> +{
>> + struct tcpa_descriptor_rev2 *tcpa;
>> +
>> + *tpm_addr = NULL;
>> + *tcpa_addr = NULL;
>> +
>> + if (has_working_tpm()) {
>> + u32 laml = 64 * 1024;
>> + *tpm_addr = malloc_high(sizeof(AmlCode_TPM));
>> +
>> + tcpa = malloc_high(sizeof(*tcpa) + laml);
>> + if (!tcpa || !*tpm_addr) {
>> + warn_noalloc();
>> + return 1;
>> + }
>> +
>> + if (*tpm_addr)
>> + memcpy(*tpm_addr, AmlCode_TPM, sizeof(AmlCode_TPM));
>> +
>> + memset(tcpa, 0x0, sizeof(*tcpa) + laml);
>> + u64 lasa = (u32)tcpa + sizeof(*tcpa);
>> +
>> + tcpa->laml = laml;
>> + tcpa->lasa = lasa;
>> + build_header((void*)tcpa, TCPA_SIGNATURE, sizeof(*tcpa), 2);
>> +
>> + *tcpa_addr = tcpa;
>> + }
>> + return 0;
>> +}
>> +
>> struct rsdp_descriptor *RsdpAddr;
>>
>> #define MAX_ACPI_TABLES 20
>> @@ -835,6 +870,12 @@ acpi_setup(void)
>> fill_dsdt(fadt, dsdt);
>> }
>>
>> + void *tcpa, *tpm;
>> + if (add_tpm_device(&tpm, &tcpa))
>> + return;
>> + ACPI_INIT_TABLE(tpm);
>> + ACPI_INIT_TABLE(tcpa);
>> +
>> // Build final rsdt table
>> struct rsdt_descriptor_rev1 *rsdt;
>> size_t rsdt_len = sizeof(*rsdt) + sizeof(u32) * tbl_idx;
>> diff --git a/src/acpi.h b/src/acpi.h
>> index 7fbd082..c2c778c 100644
>> --- a/src/acpi.h
>> +++ b/src/acpi.h
>> @@ -130,4 +130,24 @@ struct acpi_table_mcfg {
>> struct acpi_mcfg_allocation allocation[0];
>> } PACKED;
>>
>> +
>> +struct rsdt_descriptor {
>> + ACPI_TABLE_HEADER_DEF
>> + u32 entry[1];
>> +} PACKED;
>> +
>> +#define TCPA_SIGNATURE 0x41504354
>> +struct tcpa_descriptor_rev2
>> +{
>> + ACPI_TABLE_HEADER_DEF
>> + u16 platform_class;
>> + u32 laml;
>> + u64 lasa;
>> +} PACKED;
>> +
>> +/* TCPA ACPI definitions */
>> +#define TCPA_ACPI_CLASS_CLIENT 0
>> +#define TCPA_ACPI_CLASS_SERVER 1
>> +
>> +
>> #endif // acpi.h
>> diff --git a/src/config.h b/src/config.h
>> index 64e3c92..3d66568 100644
>> --- a/src/config.h
>> +++ b/src/config.h
>> @@ -17,7 +17,7 @@
>> // Maximum number of map entries in the e820 map
>> #define BUILD_MAX_E820 32
>> // Space to reserve in high-memory for tables
>> -#define BUILD_MAX_HIGHTABLE (64*1024)
>> +#define BUILD_MAX_HIGHTABLE (96*1024)
>> // Largest supported externaly facing drive id
>> #define BUILD_MAX_EXTDRIVE 16
>> // Number of bytes the smbios may be and still live in the f-segment
>> diff --git a/src/tcgbios.c b/src/tcgbios.c
>> new file mode 100644
>> index 0000000..f593a5f
>> --- /dev/null
>> +++ b/src/tcgbios.c
>> @@ -0,0 +1,70 @@
>> +// Implementation of the TCG BIOS extension according to the specification
>> +// described in
>> +// https://www.trustedcomputinggroup.org/specs/PCClient/TCG_PCClientImplementationforBIOS_1-20_1-00.pdf
>> +//
>> +// Copyright (C) 2006-2013 IBM Corporation
>> +//
>> +// Authors:
>> +// Stefan Berger <stefanb@linux.vnet.ibm.com>
>> +//
>> +// This file may be distributed under the terms of the GNU LGPLv3 license.
>> +
>> +
>> +#include "config.h"
>> +
>> +#include "types.h"
>> +#include "tpm_drivers.h" // tpm_drivers[]
>> +
>> +
>> +typedef struct {
>> + u8 tpm_probed:1;
>> + u8 tpm_found:1;
>> + u8 tpm_working:1;
>> + u8 if_shutdown:1;
>> + u8 tpm_driver_to_use:4;
>> +} tcpa_state_t;
>> +
>> +
>> +static tcpa_state_t tcpa_state = {
>> + .tpm_driver_to_use = TPM_INVALID_DRIVER,
>> +};
>> +
>> +
>> +/********************************************************
>> + Extensions for TCG-enabled BIOS
>> + *******************************************************/
>> +
>> +
>> +static u32
>> +is_tpm_present(void)
>> +{
>> + u32 rc = 0;
>> + unsigned int i;
>> +
>> + for (i = 0; i < TPM_NUM_DRIVERS; i++) {
>> + struct tpm_driver *td = &tpm_drivers[i];
>> + if (td->probe() != 0) {
>> + td->init();
>> + tcpa_state.tpm_driver_to_use = i;
>> + rc = 1;
>> + break;
>> + }
>> + }
>> +
>> + return rc;
>> +}
>> +
>> +
>> +int
>> +has_working_tpm(void)
>> +{
>> + if (!tcpa_state.tpm_probed) {
>> + tcpa_state.tpm_probed = 1;
>> + tcpa_state.tpm_found = (is_tpm_present() != 0);
>> + tcpa_state.tpm_working = 1;
>> + }
>> + if (!tcpa_state.tpm_working)
>> + return 0;
>> +
>> + return tcpa_state.tpm_found;
>> +}
>> diff --git a/src/tcgbios.h b/src/tcgbios.h
>> new file mode 100644
>> index 0000000..b6023fe
>> --- /dev/null
>> +++ b/src/tcgbios.h
>> @@ -0,0 +1,57 @@
>> +#ifndef TCGBIOS_H
>> +#define TCGBIOS_H
>> +
>> +
>> +#define TPM_OK 0x0
>> +#define TPM_RET_BASE 0x1
>> +#define TCG_GENERAL_ERROR (TPM_RET_BASE + 0x0)
>> +#define TCG_TPM_IS_LOCKED (TPM_RET_BASE + 0x1)
>> +#define TCG_NO_RESPONSE (TPM_RET_BASE + 0x2)
>> +#define TCG_INVALID_RESPONSE (TPM_RET_BASE + 0x3)
>> +#define TCG_INVALID_ACCESS_REQUEST (TPM_RET_BASE + 0x4)
>> +#define TCG_FIRMWARE_ERROR (TPM_RET_BASE + 0x5)
>> +#define TCG_INTEGRITY_CHECK_FAILED (TPM_RET_BASE + 0x6)
>> +#define TCG_INVALID_DEVICE_ID (TPM_RET_BASE + 0x7)
>> +#define TCG_INVALID_VENDOR_ID (TPM_RET_BASE + 0x8)
>> +#define TCG_UNABLE_TO_OPEN (TPM_RET_BASE + 0x9)
>> +#define TCG_UNABLE_TO_CLOSE (TPM_RET_BASE + 0xa)
>> +#define TCG_RESPONSE_TIMEOUT (TPM_RET_BASE + 0xb)
>> +#define TCG_INVALID_COM_REQUEST (TPM_RET_BASE + 0xc)
>> +#define TCG_INVALID_ADR_REQUEST (TPM_RET_BASE + 0xd)
>> +#define TCG_WRITE_BYTE_ERROR (TPM_RET_BASE + 0xe)
>> +#define TCG_READ_BYTE_ERROR (TPM_RET_BASE + 0xf)
>> +#define TCG_BLOCK_WRITE_TIMEOUT (TPM_RET_BASE + 0x10)
>> +#define TCG_CHAR_WRITE_TIMEOUT (TPM_RET_BASE + 0x11)
>> +#define TCG_CHAR_READ_TIMEOUT (TPM_RET_BASE + 0x12)
>> +#define TCG_BLOCK_READ_TIMEOUT (TPM_RET_BASE + 0x13)
>> +#define TCG_TRANSFER_ABORT (TPM_RET_BASE + 0x14)
>> +#define TCG_INVALID_DRV_FUNCTION (TPM_RET_BASE + 0x15)
>> +#define TCG_OUTPUT_BUFFER_TOO_SHORT (TPM_RET_BASE + 0x16)
>> +#define TCG_FATAL_COM_ERROR (TPM_RET_BASE + 0x17)
>> +#define TCG_INVALID_INPUT_PARA (TPM_RET_BASE + 0x18)
>> +#define TCG_TCG_COMMAND_ERROR (TPM_RET_BASE + 0x19)
>> +#define TCG_INTERFACE_SHUTDOWN (TPM_RET_BASE + 0x20)
>> +//define TCG_PC_UNSUPPORTED (TPM_RET_BASE + 0x21)
>> +#define TCG_PC_TPM_NOT_PRESENT (TPM_RET_BASE + 0x22)
>> +#define TCG_PC_TPM_DEACTIVATED (TPM_RET_BASE + 0x23)
>> +
>> +
>> +#define TPM_INVALID_ADR_REQUEST TCG_INVALID_ADR_REQUEST
>> +#define TPM_IS_LOCKED TCG_TPM_IS_LOCKED
>> +#define TPM_INVALID_DEVICE_ID TCG_INVALID_DEVICE_ID
>> +#define TPM_INVALID_VENDOR_ID TCG_INVALID_VENDOR_ID
>> +//define TPM_RESERVED_REG_INVALID
>> +#define TPM_FIRMWARE_ERROR TCG_FIRMWARE_ERROR
>> +#define TPM_UNABLE_TO_OPEN TCG_UNABLE_TO_OPEN
>> +#define TPM_UNABLE_TO_CLOSE TCG_UNABLE_TO_CLOSE
>> +#define TPM_INVALID_RESPONSE TCG_INVALID_RESPONSE
>> +#define TPM_RESPONSE_TIMEOUT TCG_RESPONSE_TIMEOUT
>> +#define TPM_INVALID_ACCESS_REQUEST TCG_INVALID_ACCESS_REQUEST
>> +#define TPM_TRANSFER_ABORT TCG_TRANSFER_ABORT
>> +#define TPM_GENERAL_ERROR TCG_GENERAL_ERROR
>> +
>> +
>> +int has_working_tpm(void);
>> +
>> +
>> +#endif /* TCGBIOS_H */
>>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-04-01 19:05 ` Corey Bryant
@ 2013-04-02 0:11 ` Kevin O'Connor
2013-04-02 14:34 ` Corey Bryant
0 siblings, 1 reply; 10+ messages in thread
From: Kevin O'Connor @ 2013-04-02 0:11 UTC (permalink / raw)
To: Corey Bryant
Cc: Paolo Bonzini, Michael S. Tsirkin, Laszlo Ersek, qemu-devel,
stefanb
On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote:
> On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
> >There is work on moving ACPI tables to QEMU. Please work with the other
> >developers (Kevin of course, and Michael and Laszlo who I have CCed) on
> >this.
>
> Kevin, Do you have a preference whether we add these ACPI tables to
> SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
> SeaBIOS and this adds probably 200 bytes of code and data.
> Basically it creates the TPM's SSDT and TCPA (for logging) and
> connects them to the RSDT.
The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So -
yes - my preference would be to add these to QEMU once the transition
is complete.
-Kevin
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-04-02 0:11 ` Kevin O'Connor
@ 2013-04-02 14:34 ` Corey Bryant
2013-04-03 9:54 ` Laszlo Ersek
0 siblings, 1 reply; 10+ messages in thread
From: Corey Bryant @ 2013-04-02 14:34 UTC (permalink / raw)
To: Kevin O'Connor
Cc: Paolo Bonzini, stefanb, Laszlo Ersek, qemu-devel,
Michael S. Tsirkin
On 04/01/2013 08:11 PM, Kevin O'Connor wrote:
> On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote:
>> On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
>>> There is work on moving ACPI tables to QEMU. Please work with the other
>>> developers (Kevin of course, and Michael and Laszlo who I have CCed) on
>>> this.
>>
>> Kevin, Do you have a preference whether we add these ACPI tables to
>> SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
>> SeaBIOS and this adds probably 200 bytes of code and data.
>> Basically it creates the TPM's SSDT and TCPA (for logging) and
>> connects them to the RSDT.
>
> The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So -
> yes - my preference would be to add these to QEMU once the transition
> is complete.
>
> -Kevin
>
Ok I'll hold off until the transition is complete. Thanks.
--
Regards,
Corey Bryant
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-04-02 14:34 ` Corey Bryant
@ 2013-04-03 9:54 ` Laszlo Ersek
2013-04-03 10:23 ` Michael S. Tsirkin
0 siblings, 1 reply; 10+ messages in thread
From: Laszlo Ersek @ 2013-04-03 9:54 UTC (permalink / raw)
To: Corey Bryant
Cc: Paolo Bonzini, Kevin O'Connor, qemu-devel, stefanb,
Michael S. Tsirkin
On 04/02/13 16:34, Corey Bryant wrote:
>
>
> On 04/01/2013 08:11 PM, Kevin O'Connor wrote:
>> On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote:
>>> On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
>>>> There is work on moving ACPI tables to QEMU. Please work with the
>>>> other
>>>> developers (Kevin of course, and Michael and Laszlo who I have CCed) on
>>>> this.
>>>
>>> Kevin, Do you have a preference whether we add these ACPI tables to
>>> SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
>>> SeaBIOS and this adds probably 200 bytes of code and data.
>>> Basically it creates the TPM's SSDT and TCPA (for logging) and
>>> connects them to the RSDT.
>>
>> The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So -
>> yes - my preference would be to add these to QEMU once the transition
>> is complete.
>>
>> -Kevin
>>
>
> Ok I'll hold off until the transition is complete. Thanks.
If that translates to "until Laszlo submits patches that are accepted",
then don't wait. I have no idea when I'll manage that and I'd hate to
block your work.
Laszlo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-04-03 9:54 ` Laszlo Ersek
@ 2013-04-03 10:23 ` Michael S. Tsirkin
2013-04-03 14:05 ` Corey Bryant
0 siblings, 1 reply; 10+ messages in thread
From: Michael S. Tsirkin @ 2013-04-03 10:23 UTC (permalink / raw)
To: Laszlo Ersek
Cc: Paolo Bonzini, Kevin O'Connor, Corey Bryant, qemu-devel,
stefanb
On Wed, Apr 03, 2013 at 11:54:57AM +0200, Laszlo Ersek wrote:
> On 04/02/13 16:34, Corey Bryant wrote:
> >
> >
> > On 04/01/2013 08:11 PM, Kevin O'Connor wrote:
> >> On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote:
> >>> On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
> >>>> There is work on moving ACPI tables to QEMU. Please work with the
> >>>> other
> >>>> developers (Kevin of course, and Michael and Laszlo who I have CCed) on
> >>>> this.
> >>>
> >>> Kevin, Do you have a preference whether we add these ACPI tables to
> >>> SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
> >>> SeaBIOS and this adds probably 200 bytes of code and data.
> >>> Basically it creates the TPM's SSDT and TCPA (for logging) and
> >>> connects them to the RSDT.
> >>
> >> The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So -
> >> yes - my preference would be to add these to QEMU once the transition
> >> is complete.
> >>
> >> -Kevin
> >>
> >
> > Ok I'll hold off until the transition is complete. Thanks.
>
> If that translates to "until Laszlo submits patches that are accepted",
> then don't wait. I have no idea when I'll manage that and I'd hate to
> block your work.
>
> Laszlo
I'm working on that too btw :) Hard to promise a schedule but
it's high on my agenda.
--
MST
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device
2013-04-03 10:23 ` Michael S. Tsirkin
@ 2013-04-03 14:05 ` Corey Bryant
0 siblings, 0 replies; 10+ messages in thread
From: Corey Bryant @ 2013-04-03 14:05 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Paolo Bonzini, Kevin O'Connor, Laszlo Ersek, qemu-devel,
stefanb
On 04/03/2013 06:23 AM, Michael S. Tsirkin wrote:
> On Wed, Apr 03, 2013 at 11:54:57AM +0200, Laszlo Ersek wrote:
>> On 04/02/13 16:34, Corey Bryant wrote:
>>>
>>>
>>> On 04/01/2013 08:11 PM, Kevin O'Connor wrote:
>>>> On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote:
>>>>> On 03/28/2013 05:03 AM, Paolo Bonzini wrote:
>>>>>> There is work on moving ACPI tables to QEMU. Please work with the
>>>>>> other
>>>>>> developers (Kevin of course, and Michael and Laszlo who I have CCed) on
>>>>>> this.
>>>>>
>>>>> Kevin, Do you have a preference whether we add these ACPI tables to
>>>>> SeaBIOS vs QEMU? It seems there are still a lot of ACPI tables in
>>>>> SeaBIOS and this adds probably 200 bytes of code and data.
>>>>> Basically it creates the TPM's SSDT and TCPA (for logging) and
>>>>> connects them to the RSDT.
>>>>
>>>> The goal is to move all of the ACPI tables from SeaBIOS to QEMU. So -
>>>> yes - my preference would be to add these to QEMU once the transition
>>>> is complete.
>>>>
>>>> -Kevin
>>>>
>>>
>>> Ok I'll hold off until the transition is complete. Thanks.
>>
>> If that translates to "until Laszlo submits patches that are accepted",
>> then don't wait. I have no idea when I'll manage that and I'd hate to
>> block your work.
>>
>> Laszlo
>
> I'm working on that too btw :) Hard to promise a schedule but
> it's high on my agenda.
>
Great, thanks. I'll watch for patches. I'd prefer to follow your lead
on this.
--
Regards,
Corey Bryant
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-04-03 14:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-26 14:14 [Qemu-devel] [PATCH 0/2] Add TPM driver and ACPI support to SeaBIOS Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 1/2] Add an implementation of a TPM TIS driver Corey Bryant
2013-03-26 14:14 ` [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device Corey Bryant
2013-03-28 9:03 ` Paolo Bonzini
2013-04-01 19:05 ` Corey Bryant
2013-04-02 0:11 ` Kevin O'Connor
2013-04-02 14:34 ` Corey Bryant
2013-04-03 9:54 ` Laszlo Ersek
2013-04-03 10:23 ` Michael S. Tsirkin
2013-04-03 14:05 ` Corey Bryant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).