From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWRD-0002sp-88 for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKWRA-0003ET-CJ for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:09:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKWRA-0003EH-5S for qemu-devel@nongnu.org; Tue, 26 Mar 2013 12:09:24 -0400 From: Stefan Hajnoczi Date: Tue, 26 Mar 2013 17:07:50 +0100 Message-Id: <1364314072-2474-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1364314072-2474-1-git-send-email-stefanha@redhat.com> References: <1364314072-2474-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/4] qemu-socket: set passed fd non-blocking in socket_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Juan Quintela , mprivozn@redhat.com, Corey Bryant , david.pravec@nethost.cz, Stefan Hajnoczi socket_connect() sets non-blocking on TCP or UNIX domain sockets if a callback function is passed. Do the same for file descriptor passing, otherwise we could unexpectedly be using a blocking file descriptor. Signed-off-by: Stefan Hajnoczi --- util/qemu-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index b6b78f5..298f6f2 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **errp, case SOCKET_ADDRESS_KIND_FD: fd = monitor_get_fd(cur_mon, addr->fd->str, errp); if (callback) { + socket_set_nonblock(fd); callback(fd, opaque); } break; -- 1.8.1.4