qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 03/21] qcow2: Remove bogus unlock of s->lock
Date: Tue, 26 Mar 2013 17:49:55 +0100	[thread overview]
Message-ID: <1364316613-31223-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1364316613-31223-1-git-send-email-kwolf@redhat.com>

The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index 8ea696a..3f7edf5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
                 QLIST_REMOVE(l2meta, next_in_flight);
             }
 
-            qemu_co_mutex_unlock(&s->lock);
             qemu_co_queue_restart_all(&l2meta->dependent_requests);
-            qemu_co_mutex_lock(&s->lock);
 
             g_free(l2meta);
             l2meta = NULL;
-- 
1.8.1.4

  parent reply	other threads:[~2013-03-26 16:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26 16:49 [Qemu-devel] [PATCH v2 00/21] qcow2: Rework cluster allocation even more Kevin Wolf
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 01/21] qemu-iotests: More concurrent allocation scenarios Kevin Wolf
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 02/21] qcow2: Fix "total clusters" number in bdrv_check Kevin Wolf
2013-03-26 16:49 ` Kevin Wolf [this message]
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 04/21] qcow2: Handle dependencies earlier Kevin Wolf
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 05/21] qcow2: Improve check for overlapping allocations Kevin Wolf
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 06/21] qcow2: Change handle_dependency to byte granularity Kevin Wolf
2013-03-26 16:49 ` [Qemu-devel] [PATCH v2 07/21] qcow2: Decouple cluster allocation from cluster reuse code Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 08/21] qcow2: Factor out handle_alloc() Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 09/21] qcow2: handle_alloc(): Get rid of nb_clusters parameter Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 10/21] qcow2: handle_alloc(): Get rid of keep_clusters parameter Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 11/21] qcow2: Finalise interface of handle_alloc() Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 12/21] qcow2: Clean up handle_alloc() Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 13/21] qcow2: Factor out handle_copied() Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 14/21] qcow2: handle_copied(): Get rid of nb_clusters parameter Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 15/21] qcow2: handle_copied(): Get rid of keep_clusters parameter Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 16/21] qcow2: handle_copied(): Implement non-zero host_offset Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 17/21] qcow2: Prepare handle_alloc/copied() for byte granularity Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 18/21] qcow2: Use byte granularity in qcow2_alloc_cluster_offset() Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 19/21] qcow2: Allow requests with multiple l2metas Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 20/21] qcow2: Move cluster gathering to a non-looping loop Kevin Wolf
2013-03-26 16:50 ` [Qemu-devel] [PATCH v2 21/21] qcow2: Gather clusters in a looping loop Kevin Wolf
2013-03-27 10:27   ` Stefan Hajnoczi
2013-03-27 10:43     ` [Qemu-devel] [PATCH v3 " Kevin Wolf
2013-03-27 10:29 ` [Qemu-devel] [PATCH v2 00/21] qcow2: Rework cluster allocation even more Stefan Hajnoczi
2013-03-27 12:41 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364316613-31223-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).