From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKmQw-0004DG-Lx for qemu-devel@nongnu.org; Wed, 27 Mar 2013 05:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKmNn-0001VB-7O for qemu-devel@nongnu.org; Wed, 27 Mar 2013 05:11:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKmNm-0001V1-S5 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 05:10:59 -0400 From: Stefan Hajnoczi Date: Wed, 27 Mar 2013 10:10:44 +0100 Message-Id: <1364375446-24180-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1364375446-24180-1-git-send-email-stefanha@redhat.com> References: <1364375446-24180-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] net: ensure "socket" backend uses non-blocking fds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Juan Quintela , mprivozn@redhat.com, coreyb@linux.vnet.ibm.com, david.pravec@nethost.cz, Luiz Capitulino , Stefan Hajnoczi There are several code paths in net_init_socket() depending on how the socket is created: file descriptor passing, UDP multicast, TCP, or UDP. Some of these support both listen and connect. Not all code paths set the socket to non-blocking. This patch addresses the file descriptor passing and UDP cases which were missing socket_set_nonblock(fd) calls. I considered moving socket_set_nonblock(fd) to a central location but it turns out the code paths are different enough to require non-blocking at different places. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index b5c8e65..87af1d3 100644 --- a/net/socket.c +++ b/net/socket.c @@ -674,6 +674,7 @@ static int net_socket_udp_init(NetClientState *peer, closesocket(fd); return -1; } + qemu_set_nonblock(fd); s = net_socket_fd_init(peer, model, name, fd, 0); if (!s) { @@ -712,7 +713,11 @@ int net_init_socket(const NetClientOptions *opts, const char *name, int fd; fd = monitor_handle_fd_param(cur_mon, sock->fd); - if (fd == -1 || !net_socket_fd_init(peer, "socket", name, fd, 1)) { + if (fd == -1) { + return -1; + } + qemu_set_nonblock(fd); + if (!net_socket_fd_init(peer, "socket", name, fd, 1)) { return -1; } return 0; -- 1.8.1.4