From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsa1-0000EH-GT for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:48:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsZn-00087P-HA for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:48:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsTV-0005Tm-Q9 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 11:41:17 -0400 From: Stefan Hajnoczi Date: Wed, 27 Mar 2013 16:41:12 +0100 Message-Id: <1364398872-3912-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] virtio-pci: pass real with_irqfd to virtio_pci_set_guest_notifier() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?=E5=BC=A0=E7=A3=8A=E5=BC=BA?= , Stefan Hajnoczi , "Michael S. Tsirkin" virtio_pci_set_guest_notifiers() checks whether irqfd can be used and whether MSI-X is enabled for the PCI adapter. But then it calls virtio_pci_set_guest_notifier() and passes kvm_msi_via_irqfd_enabled() instead of with_irqfd. When MSI-X is disabled but irqfd is allowed this means that guest_notifier has neither irqfd nor a virtio_queue_guest_notifier_read() handler. Therefore the guest cannot receive notifications. This issue is triggered by a Windows 7 Professional 64-bit guest with -device virtio-blk-pci,x-data-plane=3Don. The guest driver does not enable MSI-X and the guest gets stuck at the Windows boot screen since it does not receive notifications. Reported-by: =E5=BC=A0=E7=A3=8A=E5=BC=BA (Leiqiang Zhang) Signed-off-by: Stefan Hajnoczi --- hw/virtio-pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 736a9bf..84ece51 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -798,8 +798,7 @@ static int virtio_pci_set_guest_notifiers(DeviceState= *d, int nvqs, bool assign) break; } =20 - r =3D virtio_pci_set_guest_notifier(d, n, assign, - kvm_msi_via_irqfd_enabled()); + r =3D virtio_pci_set_guest_notifier(d, n, assign, with_irqfd); if (r < 0) { goto assign_error; } --=20 1.8.1.4