From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: owasserm@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 4/6] iov: reorganize iov_send_recv, part 3
Date: Wed, 27 Mar 2013 17:36:30 +0100 [thread overview]
Message-ID: <1364402192-18169-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1364402192-18169-1-git-send-email-pbonzini@redhat.com>
"si" and "ei" are merged in a single variable.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
util/iov.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/util/iov.c b/util/iov.c
index 110d18e..f14ff0b 100644
--- a/util/iov.c
+++ b/util/iov.c
@@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
{
ssize_t ret;
size_t orig_len, tail;
- unsigned si, ei; /* start and end indexes */
+ unsigned niov;
if (bytes == 0) {
/* Catch the do-nothing case early, as otherwise we will pass an
@@ -158,15 +158,15 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
/* Find the start position, skipping `offset' bytes:
* first, skip all full-sized vector elements, */
- for (si = 0; si < iov_cnt && offset >= iov[si].iov_len; ++si) {
- offset -= iov[si].iov_len;
+ for (niov = 0; niov < iov_cnt && offset >= iov[niov].iov_len; ++niov) {
+ offset -= iov[niov].iov_len;
}
- /* si == iov_cnt would only be valid if bytes == 0, which
+ /* niov == iov_cnt would only be valid if bytes == 0, which
* we already ruled out above. */
- assert(si < iov_cnt);
- iov += si;
- iov_cnt -= si;
+ assert(niov < iov_cnt);
+ iov += niov;
+ iov_cnt -= niov;
if (offset) {
/* second, skip `offset' bytes from the (now) first element,
@@ -177,23 +177,23 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt,
/* Find the end position skipping `bytes' bytes: */
/* first, skip all full-sized elements */
tail = bytes;
- for (ei = 0; ei < iov_cnt && iov[ei].iov_len <= tail; ++ei) {
- tail -= iov[ei].iov_len;
+ for (niov = 0; niov < iov_cnt && iov[niov].iov_len <= tail; ++niov) {
+ tail -= iov[niov].iov_len;
}
if (tail) {
/* second, fixup the last element, and remember the original
* length */
- assert(ei < iov_cnt);
- assert(iov[ei].iov_len > tail);
- orig_len = iov[ei].iov_len;
- iov[ei++].iov_len = tail;
+ assert(niov < iov_cnt);
+ assert(iov[niov].iov_len > tail);
+ orig_len = iov[niov].iov_len;
+ iov[niov++].iov_len = tail;
}
- ret = do_send_recv(sockfd, iov, ei, do_send);
+ ret = do_send_recv(sockfd, iov, niov, do_send);
/* Undo the changes above */
if (tail) {
- iov[ei-1].iov_len = orig_len;
+ iov[niov-1].iov_len = orig_len;
}
if (offset) {
iov[0].iov_base -= offset;
--
1.8.1.4
next prev parent reply other threads:[~2013-03-27 16:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 16:36 [Qemu-devel] [PATCH 0/6] migration: followups for writev patches Paolo Bonzini
2013-03-27 16:36 ` [Qemu-devel] [PATCH 1/6] qemu-file: drop socket_put_buffer Paolo Bonzini
2013-04-09 13:20 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 2/6] iov: reorganize iov_send_recv, part 1 Paolo Bonzini
2013-04-09 13:18 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 3/6] iov: reorganize iov_send_recv, part 2 Paolo Bonzini
2013-04-09 13:23 ` Juan Quintela
2013-03-27 16:36 ` Paolo Bonzini [this message]
2013-04-09 13:24 ` [Qemu-devel] [PATCH 4/6] iov: reorganize iov_send_recv, part 3 Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 5/6] iov: handle partial writes from sendmsg and recvmsg Paolo Bonzini
2013-04-09 13:27 ` Juan Quintela
2013-03-27 16:36 ` [Qemu-devel] [PATCH 6/6] qemu-file: do not use stdio for qemu_fdopen Paolo Bonzini
2013-04-09 13:30 ` Juan Quintela
2013-04-16 21:09 ` Anthony Liguori
2013-04-03 8:08 ` [Qemu-devel] [PATCH 0/6] migration: followups for writev patches Orit Wasserman
2013-04-16 15:41 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 9:46 [Qemu-devel] [PULL (rebased) " Paolo Bonzini
2013-04-17 9:46 ` [Qemu-devel] [PATCH 4/6] iov: reorganize iov_send_recv, part 3 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364402192-18169-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).