From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51609) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKvMu-0006wl-N2 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:46:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKvMs-0004Qt-TK for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:46:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKvMs-0004Qk-LJ for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:46:38 -0400 From: Luiz Capitulino Date: Wed, 27 Mar 2013 14:46:24 -0400 Message-Id: <1364409987-23742-4-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1364409987-23742-1-git-send-email-lcapitulino@redhat.com> References: <1364409987-23742-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PULL 3/6] qemu-socket: set passed fd non-blocking in socket_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com From: Stefan Hajnoczi socket_connect() sets non-blocking on TCP or UNIX domain sockets if a callback function is passed. Do the same for file descriptor passing, otherwise we could unexpectedly be using a blocking file descriptor. Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- util/qemu-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index b632a74..94581aa 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **errp, case SOCKET_ADDRESS_KIND_FD: fd = monitor_get_fd(cur_mon, addr->fd->str, errp); if (callback) { + qemu_set_nonblock(fd); callback(fd, opaque); } break; -- 1.8.1.4