From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKvTD-0005FV-I0 for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:53:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKvTA-0007DS-SZ for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:53:11 -0400 Received: from mail-qa0-f41.google.com ([209.85.216.41]:34053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKvTA-0007Cq-Ok for qemu-devel@nongnu.org; Wed, 27 Mar 2013 14:53:08 -0400 Received: by mail-qa0-f41.google.com with SMTP id bs12so1095525qab.0 for ; Wed, 27 Mar 2013 11:53:08 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Wed, 27 Mar 2013 11:52:22 -0700 Message-Id: <1364410353-24728-2-git-send-email-rth@twiddle.net> In-Reply-To: <1364410353-24728-1-git-send-email-rth@twiddle.net> References: <1364410353-24728-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 01/12] tcg-s390: Fix movi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: agraf@suse.de The code to load the high 64 bits assumed that the insn used to load the low 64 bits zero-extended. Enforce that. --- tcg/s390/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index e12a152..0132010 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -770,7 +770,7 @@ static void tcg_out_movi(TCGContext *s, TCGType type, /* If we get here, both the high and low parts have non-zero bits. */ /* Recurse to load the lower 32-bits. */ - tcg_out_movi(s, TCG_TYPE_I32, ret, sval); + tcg_out_movi(s, TCG_TYPE_I64, ret, uval & 0xffffffff); /* Insert data into the high 32-bits. */ uval = uval >> 31 >> 1; -- 1.8.1.4