From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULCsz-000079-9S for qemu-devel@nongnu.org; Thu, 28 Mar 2013 09:28:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULCqD-00087Q-3X for qemu-devel@nongnu.org; Thu, 28 Mar 2013 09:26:07 -0400 Received: from greensocs.com ([87.106.252.221]:39708 helo=s15328186.onlinehome-server.info) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULCqC-000879-Gp for qemu-devel@nongnu.org; Thu, 28 Mar 2013 09:26:04 -0400 From: fred.konrad@greensocs.com Date: Thu, 28 Mar 2013 14:25:29 +0100 Message-Id: <1364477132-17968-5-git-send-email-fred.konrad@greensocs.com> In-Reply-To: <1364477132-17968-1-git-send-email-fred.konrad@greensocs.com> References: <1364477132-17968-1-git-send-email-fred.konrad@greensocs.com> Subject: [Qemu-devel] [PATCH v3 4/7] virtio-serial-ccw: switch to the new API. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, aliguori@us.ibm.com Cc: cornelia.huck@de.ibm.com, peter.maydell@linaro.org, mark.burton@greensocs.com, fred.konrad@greensocs.com From: KONRAD Frederic Here the virtio-serial-ccw is modified for the new API. The device virtio-serial-ccw extends virtio-ccw-device as before. It creates and connects a virtio-serial during the init. The properties are not modified. Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 30 +++++++++++++++++------------- hw/s390x/virtio-ccw.h | 11 +++++++++++ 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 5dce791..d3a01cd 100644 --- a/hw/s390x/virtio-ccw.c +++ b/hw/s390x/virtio-ccw.c @@ -590,22 +590,25 @@ static void virtio_ccw_blk_instance_init(Object *obj) object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL); } -static int virtio_ccw_serial_init(VirtioCcwDevice *dev) +static int virtio_ccw_serial_init(VirtioCcwDevice *ccw_dev) { - VirtIODevice *vdev; + VirtioSerialCcw *dev = VIRTIO_SERIAL_CCW(ccw_dev); + DeviceState *vdev = DEVICE(&dev->vdev); - vdev = virtio_serial_init((DeviceState *)dev, &dev->serial); - if (!vdev) { + qdev_set_parent_bus(vdev, BUS(&ccw_dev->bus)); + if (qdev_init(vdev) < 0) { return -1; } - return virtio_ccw_device_init(dev, vdev); + return virtio_ccw_device_init(ccw_dev, VIRTIO_DEVICE(vdev)); } -static int virtio_ccw_serial_exit(VirtioCcwDevice *dev) + +static void virtio_ccw_serial_instance_init(Object *obj) { - virtio_serial_exit(dev->vdev); - return virtio_ccw_exit(dev); + VirtioSerialCcw *dev = VIRTIO_SERIAL_CCW(obj); + object_initialize(OBJECT(&dev->vdev), TYPE_VIRTIO_SERIAL); + object_property_add_child(obj, "virtio-backend", OBJECT(&dev->vdev), NULL); } static int virtio_ccw_balloon_init(VirtioCcwDevice *ccw_dev) @@ -786,8 +789,8 @@ static const TypeInfo virtio_ccw_blk = { static Property virtio_ccw_serial_properties[] = { DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id), - DEFINE_PROP_UINT32("max_ports", VirtioCcwDevice, - serial.max_virtserial_ports, 31), + DEFINE_PROP_UINT32("max_ports", VirtioSerialCcw, + vdev.serial.max_virtserial_ports, 31), DEFINE_VIRTIO_COMMON_FEATURES(VirtioCcwDevice, host_features[0]), DEFINE_PROP_END_OF_LIST(), }; @@ -798,15 +801,16 @@ static void virtio_ccw_serial_class_init(ObjectClass *klass, void *data) VirtIOCCWDeviceClass *k = VIRTIO_CCW_DEVICE_CLASS(klass); k->init = virtio_ccw_serial_init; - k->exit = virtio_ccw_serial_exit; + k->exit = virtio_ccw_exit; dc->reset = virtio_ccw_reset; dc->props = virtio_ccw_serial_properties; } static const TypeInfo virtio_ccw_serial = { - .name = "virtio-serial-ccw", + .name = TYPE_VIRTIO_SERIAL_CCW, .parent = TYPE_VIRTIO_CCW_DEVICE, - .instance_size = sizeof(VirtioCcwDevice), + .instance_size = sizeof(VirtioSerialCcw), + .instance_init = virtio_ccw_serial_instance_init, .class_init = virtio_ccw_serial_class_init, }; diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h index d580510..bf6c828 100644 --- a/hw/s390x/virtio-ccw.h +++ b/hw/s390x/virtio-ccw.h @@ -127,6 +127,17 @@ typedef struct VirtIOBalloonCcw { VirtIOBalloon vdev; } VirtIOBalloonCcw; +/* virtio-serial-ccw */ + +#define TYPE_VIRTIO_SERIAL_CCW "virtio-serial-ccw" +#define VIRTIO_SERIAL_CCW(obj) \ + OBJECT_CHECK(VirtioSerialCcw, (obj), TYPE_VIRTIO_SERIAL_CCW) + +typedef struct VirtioSerialCcw { + VirtioCcwDevice parent_obj; + VirtIOSerial vdev; +} VirtioSerialCcw; + VirtualCssBus *virtual_css_bus_init(void); void virtio_ccw_device_update_status(SubchDev *sch); VirtIODevice *virtio_ccw_get_vdev(SubchDev *sch); -- 1.7.11.7