From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Anthony Liguori" <aliguori@us.ibm.com>,
"Lluís Vilanova" <vilanova@ac.upc.edu>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 04/11] trace: [monitor] Use new event control interface
Date: Thu, 28 Mar 2013 14:25:45 +0100 [thread overview]
Message-ID: <1364477152-26994-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1364477152-26994-1-git-send-email-stefanha@redhat.com>
From: Lluís Vilanova <vilanova@ac.upc.edu>
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
monitor.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 5dfae2a..4ec1db9 100644
--- a/monitor.c
+++ b/monitor.c
@@ -761,9 +761,18 @@ static void do_trace_event_set_state(Monitor *mon, const QDict *qdict)
{
const char *tp_name = qdict_get_str(qdict, "name");
bool new_state = qdict_get_bool(qdict, "option");
- int ret = trace_event_set_state(tp_name, new_state);
- if (!ret) {
+ bool found = false;
+ TraceEvent *ev = NULL;
+ while ((ev = trace_event_pattern(tp_name, ev)) != NULL) {
+ found = true;
+ if (!trace_event_get_state_static(ev)) {
+ monitor_printf(mon, "event \"%s\" is not traceable\n", tp_name);
+ } else {
+ trace_event_set_state_dynamic(ev, new_state);
+ }
+ }
+ if (!trace_event_is_pattern(tp_name) && !found) {
monitor_printf(mon, "unknown event name \"%s\"\n", tp_name);
}
}
--
1.8.1.4
next prev parent reply other threads:[~2013-03-28 13:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:25 [Qemu-devel] [PULL 00/11] Tracing patches Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 01/11] trace: [tracetool] Explicitly identify public backends Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 02/11] trace: Provide a generic tracing event descriptor Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 03/11] trace: Provide a detailed event control interface Stefan Hajnoczi
2013-03-28 13:25 ` Stefan Hajnoczi [this message]
2013-03-28 13:25 ` [Qemu-devel] [PATCH 05/11] trace: [default] Port to generic event information and new " Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 06/11] trace: [simple] " Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 07/11] trace: [stderr] " Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 08/11] trace: rebuild generated-events.o when configuration changes Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 09/11] .gitignore: add trace/generated-events.[ch] Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 10/11] .gitignore: rename trace/generated-tracers.dtrace Stefan Hajnoczi
2013-03-28 13:25 ` [Qemu-devel] [PATCH 11/11] vl: add runstate_set tracepoint Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364477152-26994-5-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).