From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFsq-0005KO-0W for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:41:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULFsm-0002Ah-Bh for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:40:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULFsm-0002AY-4h for qemu-devel@nongnu.org; Thu, 28 Mar 2013 12:40:56 -0400 From: Stefan Hajnoczi Date: Thu, 28 Mar 2013 17:40:18 +0100 Message-Id: <1364488837-15916-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1364488837-15916-1-git-send-email-stefanha@redhat.com> References: <1364488837-15916-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 04/23] qcow2: Remove bogus unlock of s->lock List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi From: Kevin Wolf The unlock wakes up the next coroutine, but the currently running coroutine will lock it again before it yields, so this doesn't make a lot of sense. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/qcow2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8ea696a..3f7edf5 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs, QLIST_REMOVE(l2meta, next_in_flight); } - qemu_co_mutex_unlock(&s->lock); qemu_co_queue_restart_all(&l2meta->dependent_requests); - qemu_co_mutex_lock(&s->lock); g_free(l2meta); l2meta = NULL; -- 1.8.1.4