From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULRAv-0000F4-7Q for qemu-devel@nongnu.org; Fri, 29 Mar 2013 00:44:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULRAt-0004h9-Qy for qemu-devel@nongnu.org; Fri, 29 Mar 2013 00:44:25 -0400 Received: from mail.linux-iscsi.org ([67.23.28.174]:48521 helo=linux-iscsi.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULRAt-0004h5-La for qemu-devel@nongnu.org; Fri, 29 Mar 2013 00:44:23 -0400 From: "Nicholas A. Bellinger" Date: Fri, 29 Mar 2013 04:33:12 +0000 Message-Id: <1364531592-8368-4-git-send-email-nab@linux-iscsi.org> In-Reply-To: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org> References: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org> Subject: [Qemu-devel] [PATCH 3/3] vhost: Check+skip uninitialized VQs in vhost_verify_ring_mappings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: target-devel Cc: kvm-devel , "Michael S. Tsirkin" , qemu-devel , Nicholas Bellinger , lf-virt , Anthony Liguori , Stefan Hajnoczi , Paolo Bonzini , Asias He From: Nicholas Bellinger With the virtio_queue_valid() checks in place to skip uninitialized VQs within virtio-pci code, go ahead and skip the same uninitialized VQs during vhost_verify_ring_mappings(). Note this patch does not prevent vhost_virtqueue_start() from executing by checking virtio_queue_valid(), as other logic during seabios -> virtio-scsi LLD guest hand-off appears to depend upon this execution. Cc: Michael S. Tsirkin Cc: Asias He Cc: Paolo Bonzini Signed-off-by: Nicholas Bellinger --- hw/vhost.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/vhost.c b/hw/vhost.c index 4d6aee3..3a71aee 100644 --- a/hw/vhost.c +++ b/hw/vhost.c @@ -314,6 +314,9 @@ static int vhost_verify_ring_mappings(struct vhost_dev *dev, hwaddr l; void *p; + if (!vq->ring_phys || !vq->ring_size) { + continue; + } if (!ranges_overlap(start_addr, size, vq->ring_phys, vq->ring_size)) { continue; } -- 1.7.2.5