qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bruce Rogers <brogers@suse.com>
To: qemu-devel@nongnu.org
Cc: Bruce Rogers <brogers@suse.com>,
	qemu-stable@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown
Date: Mon,  1 Apr 2013 10:57:49 -0600	[thread overview]
Message-ID: <1364835469-9317-1-git-send-email-brogers@suse.com> (raw)

While investigating why a 32 bit Windows 2003 guest wasn't able to
successfully perform a shutdown /h, it was discovered that commit
afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the
initialization of the s4_val used to handle s4 shutdown.
Initialize the value as before.

Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 hw/acpi.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/acpi.c b/hw/acpi.c
index 53e47d5..26b67a8 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -474,6 +474,7 @@ static const MemoryRegionOps acpi_pm_cnt_ops = {
 
 void acpi_pm1_cnt_init(ACPIREGS *ar, MemoryRegion *parent)
 {
+    ar->pm1.cnt.s4_val = 2;
     ar->wakeup.notify = acpi_notify_wakeup;
     qemu_register_wakeup_notifier(&ar->wakeup);
     memory_region_init_io(&ar->pm1.cnt.io, &acpi_pm_cnt_ops, ar, "acpi-cnt", 2);
-- 
1.7.7

             reply	other threads:[~2013-04-01 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 16:57 Bruce Rogers [this message]
2013-04-02 10:03 ` [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown Gerd Hoffmann
2013-04-02 17:57   ` Bruce Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364835469-9317-1-git-send-email-brogers@suse.com \
    --to=brogers@suse.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).