From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMifs-0008JA-Pz for qemu-devel@nongnu.org; Mon, 01 Apr 2013 13:37:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMifr-000439-AV for qemu-devel@nongnu.org; Mon, 01 Apr 2013 13:37:40 -0400 From: Bruce Rogers Date: Mon, 1 Apr 2013 10:57:49 -0600 Message-Id: <1364835469-9317-1-git-send-email-brogers@suse.com> Subject: [Qemu-devel] [PATCH] acpi: initialize s4_val used in s4 shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bruce Rogers , qemu-stable@nongnu.org, kraxel@redhat.com While investigating why a 32 bit Windows 2003 guest wasn't able to successfully perform a shutdown /h, it was discovered that commit afafe4bbe0cf7d3318e1ac7b40925561f86a6bd4 inadvertently dropped the initialization of the s4_val used to handle s4 shutdown. Initialize the value as before. Signed-off-by: Bruce Rogers --- hw/acpi.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index 53e47d5..26b67a8 100644 --- a/hw/acpi.c +++ b/hw/acpi.c @@ -474,6 +474,7 @@ static const MemoryRegionOps acpi_pm_cnt_ops = { void acpi_pm1_cnt_init(ACPIREGS *ar, MemoryRegion *parent) { + ar->pm1.cnt.s4_val = 2; ar->wakeup.notify = acpi_notify_wakeup; qemu_register_wakeup_notifier(&ar->wakeup); memory_region_init_io(&ar->pm1.cnt.io, &acpi_pm_cnt_ops, ar, "acpi-cnt", 2); -- 1.7.7