From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60746)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMoVW-0000zY-AQ
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 19:51:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMoVV-0007z0-4s
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 19:51:22 -0400
Received: from mail.linux-iscsi.org ([67.23.28.174]:54322 helo=linux-iscsi.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMoVV-0007yw-0O
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 19:51:21 -0400
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
In-Reply-To: <20130331074559.GD23484@redhat.com>
References: <1364531592-8368-1-git-send-email-nab@linux-iscsi.org>
	<20130331074559.GD23484@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 01 Apr 2013 16:51:18 -0700
Message-ID: <1364860278.20769.67.camel@haakon2.linux-iscsi.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] virtio/vhost: Add checks for
	uninitialized VQs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, lf-virt <virtualization@lists.linux-foundation.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, target-devel <target-devel@vger.kernel.org>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>

On Sun, 2013-03-31 at 10:46 +0300, Michael S. Tsirkin wrote:
> On Fri, Mar 29, 2013 at 04:33:09AM +0000, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > Hi folks,
> > 
> > This series adds a virtio_queue_valid() for use by virtio-pci code in
> > order to prevent opreations upon uninitialized VQs, that is currently
> > expected to occur during seabios setup of virtio-scsi.
> > 
> > This also includes a vhost specific check for uninitialized VQs in
> > vhost_verify_ring_mappings() to avoid this same case.
> > 
> > Please review.
> > 
> > --nab
> 
> Okay, and does this fix the failures in vhost_verify_ring_mappings
> that you've observed?
> 

Unfortunately, no.  I've done some more digging and will follow up with
additional details on the original thread shortly..

--nab