From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMonG-0003ee-3m
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 20:09:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMonD-0004zW-SL
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 20:09:42 -0400
Received: from mail.linux-iscsi.org ([67.23.28.174]:39640 helo=linux-iscsi.org)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nab@linux-iscsi.org>) id 1UMonD-0004zK-NA
	for qemu-devel@nongnu.org; Mon, 01 Apr 2013 20:09:39 -0400
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Date: Mon,  1 Apr 2013 23:58:21 +0000
Message-Id: <1364860704-11896-1-git-send-email-nab@linux-iscsi.org>
Subject: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for
	uninitialized VQs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: target-devel <target-devel@vger.kernel.org>
Cc: kvm-devel <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Nicholas Bellinger <nab@linux-iscsi.org>, lf-virt <virtualization@lists.linux-foundation.org>, Anthony Liguori <aliguori@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Asias He <asias@redhat.com>

From: Nicholas Bellinger <nab@linux-iscsi.org>

Hi folks,

This series adds a virtio_queue_valid() for use by virtio-pci code in
order to prevent opreations upon uninitialized VQs, which is currently
expected to occur during seabios setup of virtio-scsi with in-flight
vhost-scsi-pci device code.

On the vhost side, it also adds virtio_queue_valid() sanity checks in
vhost_virtqueue_[start,stop]() and vhost_verify_ring_mappings() in order
to skip the same uninitialized VQs.

Changes from v1:
  - Remove now unnecessary virtio_queue_get_num() calls in virtio-pci.c
  - Add virtio_queue_valid() calls in vhost_virtqueue_[start,stop]()

Please review.

--nab

Michael S. Tsirkin (1):
  virtio: add API to check that ring is setup

Nicholas Bellinger (2):
  virtio-pci: Add virtio_queue_valid checks ahead of
    virtio_queue_get_num
  vhost: Skip uninitialized VQs in vhost_virtqueue_[start,stop]

 hw/vhost.c      |   12 ++++++++++++
 hw/virtio-pci.c |   34 +++++++++++++++-------------------
 hw/virtio.c     |    5 +++++
 hw/virtio.h     |    1 +
 4 files changed, 33 insertions(+), 19 deletions(-)

-- 
1.7.2.5