From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 3/4] qemu-socket: set passed fd non-blocking in socket_connect()
Date: Tue, 2 Apr 2013 11:49:46 -0400 [thread overview]
Message-ID: <1364917787-17689-4-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1364917787-17689-1-git-send-email-lcapitulino@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
socket_connect() sets non-blocking on TCP or UNIX domain sockets if a
callback function is passed. Do the same for file descriptor passing,
otherwise we could unexpectedly be using a blocking file descriptor.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
util/qemu-sockets.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index b632a74..94581aa 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -910,6 +910,7 @@ int socket_connect(SocketAddress *addr, Error **errp,
case SOCKET_ADDRESS_KIND_FD:
fd = monitor_get_fd(cur_mon, addr->fd->str, errp);
if (callback) {
+ qemu_set_nonblock(fd);
callback(fd, opaque);
}
break;
--
1.8.1.4
next prev parent reply other threads:[~2013-04-02 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 15:49 [Qemu-devel] [PULL v2 0/4] QMP queue Luiz Capitulino
2013-04-02 15:49 ` [Qemu-devel] [PULL 1/4] oslib-posix: rename socket_set_nonblock() to qemu_set_nonblock() Luiz Capitulino
2013-04-02 15:49 ` [Qemu-devel] [PULL 2/4] net: ensure "socket" backend uses non-blocking fds Luiz Capitulino
2013-04-02 15:49 ` Luiz Capitulino [this message]
2013-04-02 15:49 ` [Qemu-devel] [PULL 4/4] chardev: clear O_NONBLOCK on SCM_RIGHTS file descriptors Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364917787-17689-4-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).