From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/2] hw/sm501: Use correct setter for sysbus-ohci dma-address property
Date: Tue, 2 Apr 2013 17:10:43 +0100 [thread overview]
Message-ID: <1364919044-18413-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1364919044-18413-1-git-send-email-peter.maydell@linaro.org>
The sysbus-ohci dma-address property is declared as a HEX64
property, not a TADDR, so use the correct setter for it.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/sm501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sm501.c b/hw/sm501.c
index 93a06c9..0ef6b8a 100644
--- a/hw/sm501.c
+++ b/hw/sm501.c
@@ -1430,7 +1430,7 @@ void sm501_init(MemoryRegion *address_space_mem, uint32_t base,
/* bridge to usb host emulation module */
dev = qdev_create(NULL, "sysbus-ohci");
qdev_prop_set_uint32(dev, "num-ports", 2);
- qdev_prop_set_taddr(dev, "dma-offset", base);
+ qdev_prop_set_uint64(dev, "dma-offset", base);
qdev_init_nofail(dev);
sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0,
base + MMIO_BASE_OFFSET + SM501_USB_HOST);
--
1.7.11.4
next prev parent reply other threads:[~2013-04-02 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-02 16:10 [Qemu-devel] [PATCH 0/2] Drop support for qdev taddr properties Peter Maydell
2013-04-02 16:10 ` Peter Maydell [this message]
2013-04-02 16:10 ` [Qemu-devel] [PATCH 2/2] qdev: Drop " Peter Maydell
2013-04-02 16:42 ` [Qemu-devel] [PATCH 0/2] Drop support for qdev " Paolo Bonzini
2013-04-02 17:07 ` Peter Maydell
2013-04-02 19:09 ` Paolo Bonzini
2013-04-02 20:33 ` Peter Maydell
2013-04-02 20:39 ` Paolo Bonzini
2013-04-02 20:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364919044-18413-2-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).