From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UN96F-0006lv-Fg for qemu-devel@nongnu.org; Tue, 02 Apr 2013 17:50:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UN96E-0008PR-By for qemu-devel@nongnu.org; Tue, 02 Apr 2013 17:50:39 -0400 Sender: fluxion From: Michael Roth Date: Tue, 2 Apr 2013 16:45:08 -0500 Message-Id: <1364939142-30066-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1364939142-30066-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1364939142-30066-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 03/37] block: complete all IOs before .bdrv_truncate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Peter Lieven bdrv_truncate() invalidates the bdrv_check_request() result for in-flight requests, so there should better be none. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Lieven Reported-by: Kevin Wolf Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf (cherry picked from commit 9a665b2b8640e464f0a778216fc2dca8d02acf33) Signed-off-by: Michael Roth --- block.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block.c b/block.c index 50dab8e..11f162b 100644 --- a/block.c +++ b/block.c @@ -2427,6 +2427,10 @@ int bdrv_truncate(BlockDriverState *bs, int64_t offset) return -EACCES; if (bdrv_in_use(bs)) return -EBUSY; + + /* There better not be any in-flight IOs when we truncate the device. */ + bdrv_drain_all(); + ret = drv->bdrv_truncate(bs, offset); if (ret == 0) { ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS); -- 1.7.9.5