qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 01/10] usb-redir: Fix crash on migration with no client connected
Date: Wed,  3 Apr 2013 11:43:31 +0200	[thread overview]
Message-ID: <1364982220-4755-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1364982220-4755-1-git-send-email-kraxel@redhat.com>

From: Hans de Goede <hdegoede@redhat.com>

If no client is connected on the src side, then we won't receive a
parser during migrate, in this case usbredir_post_load() should be a nop,
rather then to try to derefefence the NULL dev->parser pointer.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/redirect.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index d02a7b9..cf66df1 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1973,6 +1973,10 @@ static int usbredir_post_load(void *priv, int version_id)
 {
     USBRedirDevice *dev = priv;
 
+    if (dev->parser == NULL) {
+        return 0;
+    }
+
     switch (dev->device_info.speed) {
     case usb_redir_speed_low:
         dev->dev.speed = USB_SPEED_LOW;
-- 
1.7.9.7

  reply	other threads:[~2013-04-03  9:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03  9:43 [Qemu-devel] [PULL 00/10] usb patch queue Gerd Hoffmann
2013-04-03  9:43 ` Gerd Hoffmann [this message]
2013-04-03  9:43 ` [Qemu-devel] [PATCH 02/10] usb-redir: Add flow control support Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 03/10] xhci: fix numintrs sanity checks Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 04/10] xhci: remove leftover debug printf Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 05/10] xhci: remove unimplemented printfs Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 06/10] xhci: zap unused name field Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 07/10] usb-hub: limit chain length Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 08/10] usb-hub: report status changes only once Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 09/10] usb: update docs for bus name change Gerd Hoffmann
2013-04-03  9:43 ` [Qemu-devel] [PATCH 10/10] usb-tablet: Don't claim wakeup capability for USB-2 version Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1364982220-4755-2-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).