From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aurelien@aurel32.net, pmaydell@linaro.org
Subject: [Qemu-devel] [PATCH v2 02/10] elfload: fix size of registers for N32
Date: Wed, 3 Apr 2013 12:32:00 +0200 [thread overview]
Message-ID: <1364985128-23772-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1364985128-23772-1-git-send-email-pbonzini@redhat.com>
Registers are 64-bit in size for the MIPS n32 ABI. Define
target_elf_greg_t accordingly, and use the correct function
to do endian swaps.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
linux-user/elfload.c | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index d3589ff..9d5dbb8 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -101,7 +101,14 @@ enum {
#define ELF_DATA ELFDATA2LSB
#endif
+#ifdef TARGET_ABI_MIPSN32
typedef target_ulong target_elf_greg_t;
+#define tswapreg(ptr) tswapl(ptr)
+#else
+typedef abi_ulong target_elf_greg_t;
+#define tswapreg(ptr) tswapal(ptr)
+#endif
+
#ifdef USE_UID16
typedef target_ushort target_uid_t;
typedef target_ushort target_gid_t;
@@ -747,17 +754,17 @@ static void elf_core_copy_regs(target_elf_gregset_t *regs, const CPUMIPSState *e
(*regs)[TARGET_EF_R0] = 0;
for (i = 1; i < ARRAY_SIZE(env->active_tc.gpr); i++) {
- (*regs)[TARGET_EF_R0 + i] = tswapl(env->active_tc.gpr[i]);
+ (*regs)[TARGET_EF_R0 + i] = tswapreg(env->active_tc.gpr[i]);
}
(*regs)[TARGET_EF_R26] = 0;
(*regs)[TARGET_EF_R27] = 0;
- (*regs)[TARGET_EF_LO] = tswapl(env->active_tc.LO[0]);
- (*regs)[TARGET_EF_HI] = tswapl(env->active_tc.HI[0]);
- (*regs)[TARGET_EF_CP0_EPC] = tswapl(env->active_tc.PC);
- (*regs)[TARGET_EF_CP0_BADVADDR] = tswapl(env->CP0_BadVAddr);
- (*regs)[TARGET_EF_CP0_STATUS] = tswapl(env->CP0_Status);
- (*regs)[TARGET_EF_CP0_CAUSE] = tswapl(env->CP0_Cause);
+ (*regs)[TARGET_EF_LO] = tswapreg(env->active_tc.LO[0]);
+ (*regs)[TARGET_EF_HI] = tswapreg(env->active_tc.HI[0]);
+ (*regs)[TARGET_EF_CP0_EPC] = tswapreg(env->active_tc.PC);
+ (*regs)[TARGET_EF_CP0_BADVADDR] = tswapreg(env->CP0_BadVAddr);
+ (*regs)[TARGET_EF_CP0_STATUS] = tswapreg(env->CP0_Status);
+ (*regs)[TARGET_EF_CP0_CAUSE] = tswapreg(env->CP0_Cause);
}
#define USE_ELF_CORE_DUMP
--
1.8.1.4
next prev parent reply other threads:[~2013-04-03 10:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 10:31 [Qemu-devel] [PATCH v2 00/10] TARGET_*_ALIGNMENT cleanup, and config-target.mak trimming Paolo Bonzini
2013-04-03 10:31 ` [Qemu-devel] [PATCH v2 01/10] elfload: fix size of ABI-dependent fields in core dumps Paolo Bonzini
2013-04-04 13:51 ` Peter Maydell
2013-04-03 10:32 ` Paolo Bonzini [this message]
2013-04-04 15:32 ` [Qemu-devel] [PATCH v2 02/10] elfload: fix size of registers for N32 Peter Maydell
2013-04-04 15:41 ` Paolo Bonzini
2013-04-04 15:46 ` Peter Maydell
2013-04-04 16:00 ` Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 03/10] elfload: use tswapreg consistently in elf_core_copy_regs Paolo Bonzini
2013-04-04 15:33 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 04/10] elfload: use abi_short/ushort instead of target_short/ushort Paolo Bonzini
2013-04-04 13:52 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 05/10] elfload: use abi_int/uint instead of target_int/uint Paolo Bonzini
2013-04-04 13:56 ` Peter Maydell
2013-04-04 14:04 ` Paolo Bonzini
2013-04-04 14:22 ` Peter Maydell
2013-04-04 14:28 ` Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 06/10] elfload: only give abi_long/ulong the alignment specified by the target Paolo Bonzini
2013-04-04 14:09 ` Peter Maydell
2013-04-04 14:11 ` Paolo Bonzini
2013-04-04 14:18 ` Peter Maydell
2013-04-04 14:26 ` Paolo Bonzini
2013-04-04 14:37 ` Peter Maydell
2013-04-04 14:45 ` Paolo Bonzini
2013-04-04 14:50 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 07/10] elfload: use abi_llong/ullong instead of target_llong/ullong Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 08/10] configure: move CONFIG_QEMU_LDST_OPTIMIZATION to config-host.mak Paolo Bonzini
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 09/10] configure: move common libraries " Paolo Bonzini
2013-04-04 13:40 ` Peter Maydell
2013-04-03 10:32 ` [Qemu-devel] [PATCH v2 10/10] configure: CONFIG_NO_XEN is duplicated Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364985128-23772-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aurelien@aurel32.net \
--cc=pmaydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).