qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabien Chouteau <chouteau@adacore.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH 1/3] PPC PReP: Load ELF kernel
Date: Wed,  3 Apr 2013 18:40:11 +0200	[thread overview]
Message-ID: <1365007213-27603-2-git-send-email-chouteau@adacore.com> (raw)
In-Reply-To: <1365007213-27603-1-git-send-email-chouteau@adacore.com>

It is useful to be able to boot non-binary (i.e. ELF) kernels directly,
as it is simpler to use and it makes symbols available in -d in_asm.

Also remove, unnecessary exit() after hw_error().

Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
 hw/ppc/prep.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 2920911..a2730c8 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -41,6 +41,7 @@
 #include "sysemu/blockdev.h"
 #include "sysemu/arch_init.h"
 #include "exec/address-spaces.h"
+#include "elf.h"
 
 //#define HARD_DEBUG_PPC_IO
 //#define DEBUG_PPC_IO
@@ -521,12 +522,17 @@ static void ppc_prep_init(QEMUMachineInitArgs *args)
 
     if (linux_boot) {
         kernel_base = KERNEL_LOAD_ADDR;
-        /* now we can load the kernel */
-        kernel_size = load_image_targphys(kernel_filename, kernel_base,
-                                          ram_size - kernel_base);
+
+        /* Try to load the kernel as an ELF file */
+        kernel_size = load_elf(kernel_filename, NULL, NULL, NULL, NULL, NULL,
+                               1, ELF_MACHINE, 0);
+        if (kernel_size < 0) {
+            /* Try to load the kernel as an binary file */
+            kernel_size = load_image_targphys(kernel_filename, kernel_base,
+                                              ram_size - kernel_base);
+        }
         if (kernel_size < 0) {
             hw_error("qemu: could not load kernel '%s'\n", kernel_filename);
-            exit(1);
         }
         /* load initrd */
         if (initrd_filename) {
-- 
1.7.9.5

  reply	other threads:[~2013-04-03 16:40 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 16:40 [Qemu-devel] [PATCH 0/3] PPC PReP: Use ElF kernel on PReP Fabien Chouteau
2013-04-03 16:40 ` Fabien Chouteau [this message]
2013-04-03 16:40 ` [Qemu-devel] [PATCH 2/3] PPC PReP: Use kernel entry to set nip at reset Fabien Chouteau
2013-04-03 16:40 ` [Qemu-devel] [PATCH 3/3] PPC PReP: can run without bios image Fabien Chouteau
2013-04-03 16:59   ` Alexander Graf
2013-04-04  8:37     ` Fabien Chouteau
2013-04-04  9:26       ` Alexander Graf
2013-04-04 16:19         ` Fabien Chouteau
2013-04-04  9:46       ` Artyom Tarasenko
2013-04-04  9:50         ` Alexander Graf
2013-04-04  9:57           ` Artyom Tarasenko
2013-04-04 11:53             ` Andreas Färber
2013-04-04 11:59               ` Alexander Graf
2013-04-05 23:00                 ` Scott Wood
2013-04-06  9:01                   ` Alexander Graf
2013-04-08 17:52                     ` Scott Wood
2013-07-04  8:35                       ` Julio Guerra
2013-07-10  9:16                         ` Julio Guerra
2013-04-06  9:07                   ` Alexander Graf
2013-04-06 11:27                     ` Peter Maydell
2013-04-06 11:38                       ` Alexander Graf
2013-04-06 13:08                         ` Peter Maydell
2013-04-06 20:07                         ` [Qemu-devel] [Qemu-ppc] " Edgar E. Iglesias
2013-04-06 20:12                           ` Alexander Graf
2013-04-07  0:52                             ` Edgar E. Iglesias
2013-04-04 12:43               ` [Qemu-devel] " Peter Maydell
2013-04-04 16:17                 ` Fabien Chouteau
2013-04-04 16:20                   ` Peter Maydell
2013-04-04 16:26                     ` Artyom Tarasenko
2013-04-04 16:30                       ` Peter Maydell
2013-04-04 16:34                         ` Alexander Graf
2013-04-04 16:41                           ` Peter Maydell
2013-04-04 16:51                             ` Alexander Graf
2013-04-04 16:52                               ` Peter Maydell
2013-04-04 22:32                                 ` Alexander Graf
2013-04-04 22:35                                   ` Peter Maydell
2013-04-04 16:46                         ` Artyom Tarasenko
2013-04-04 16:51                           ` Peter Maydell
2013-04-04 17:08                             ` Artyom Tarasenko
2013-04-04 17:22                       ` Andreas Färber
2013-04-05  9:19                         ` Fabien Chouteau
2013-04-05  9:30                           ` Peter Maydell
2013-04-04 17:05                   ` Andreas Färber
2013-04-05  2:32             ` Rob Landley
2013-04-04 11:16       ` Andreas Färber
2013-04-04 16:18         ` Fabien Chouteau
2013-04-03 16:47 ` [Qemu-devel] [PATCH 0/3] PPC PReP: Use ElF kernel on PReP Alexander Graf
2013-04-03 17:32   ` Andreas Färber
2013-04-04  8:17     ` Fabien Chouteau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365007213-27603-2-git-send-email-chouteau@adacore.com \
    --to=chouteau@adacore.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).