From: Fabien Chouteau <chouteau@adacore.com>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH 3/3] PPC PReP: can run without bios image
Date: Wed, 3 Apr 2013 18:40:13 +0200 [thread overview]
Message-ID: <1365007213-27603-4-git-send-email-chouteau@adacore.com> (raw)
In-Reply-To: <1365007213-27603-1-git-send-email-chouteau@adacore.com>
If we use an ELF kernel there's no need for bios. '-bios -' means no
bios.
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
hw/ppc/prep.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index 12198ff..8acec46 100644
--- a/hw/ppc/prep.c
+++ b/hw/ppc/prep.c
@@ -517,13 +517,22 @@ static void ppc_prep_init(QEMUMachineInitArgs *args)
memory_region_set_readonly(bios, true);
memory_region_add_subregion(sysmem, (uint32_t)(-BIOS_SIZE), bios);
vmstate_register_ram_global(bios);
- if (bios_name == NULL)
- bios_name = BIOS_FILENAME;
- filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
- if (filename) {
- bios_size = get_image_size(filename);
- } else {
+
+ if (bios_name != NULL && strcmp(bios_name, "-") == 0) {
+ /* No bios */
bios_size = -1;
+ filename = NULL;
+ } else {
+ if (bios_name == NULL) {
+ /* Default bios */
+ bios_name = BIOS_FILENAME;
+ }
+ filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name);
+ if (filename != NULL) {
+ bios_size = get_image_size(filename);
+ } else {
+ bios_size = -1;
+ }
}
if (bios_size > 0 && bios_size <= BIOS_SIZE) {
hwaddr bios_addr;
@@ -531,7 +540,7 @@ static void ppc_prep_init(QEMUMachineInitArgs *args)
bios_addr = (uint32_t)(-bios_size);
bios_size = load_image_targphys(filename, bios_addr, bios_size);
}
- if (bios_size < 0 || bios_size > BIOS_SIZE) {
+ if (filename != NULL && (bios_size < 0 || bios_size > BIOS_SIZE)) {
hw_error("qemu: could not load PPC PREP bios '%s'\n", bios_name);
}
if (filename) {
--
1.7.9.5
next prev parent reply other threads:[~2013-04-03 16:40 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 16:40 [Qemu-devel] [PATCH 0/3] PPC PReP: Use ElF kernel on PReP Fabien Chouteau
2013-04-03 16:40 ` [Qemu-devel] [PATCH 1/3] PPC PReP: Load ELF kernel Fabien Chouteau
2013-04-03 16:40 ` [Qemu-devel] [PATCH 2/3] PPC PReP: Use kernel entry to set nip at reset Fabien Chouteau
2013-04-03 16:40 ` Fabien Chouteau [this message]
2013-04-03 16:59 ` [Qemu-devel] [PATCH 3/3] PPC PReP: can run without bios image Alexander Graf
2013-04-04 8:37 ` Fabien Chouteau
2013-04-04 9:26 ` Alexander Graf
2013-04-04 16:19 ` Fabien Chouteau
2013-04-04 9:46 ` Artyom Tarasenko
2013-04-04 9:50 ` Alexander Graf
2013-04-04 9:57 ` Artyom Tarasenko
2013-04-04 11:53 ` Andreas Färber
2013-04-04 11:59 ` Alexander Graf
2013-04-05 23:00 ` Scott Wood
2013-04-06 9:01 ` Alexander Graf
2013-04-08 17:52 ` Scott Wood
2013-07-04 8:35 ` Julio Guerra
2013-07-10 9:16 ` Julio Guerra
2013-04-06 9:07 ` Alexander Graf
2013-04-06 11:27 ` Peter Maydell
2013-04-06 11:38 ` Alexander Graf
2013-04-06 13:08 ` Peter Maydell
2013-04-06 20:07 ` [Qemu-devel] [Qemu-ppc] " Edgar E. Iglesias
2013-04-06 20:12 ` Alexander Graf
2013-04-07 0:52 ` Edgar E. Iglesias
2013-04-04 12:43 ` [Qemu-devel] " Peter Maydell
2013-04-04 16:17 ` Fabien Chouteau
2013-04-04 16:20 ` Peter Maydell
2013-04-04 16:26 ` Artyom Tarasenko
2013-04-04 16:30 ` Peter Maydell
2013-04-04 16:34 ` Alexander Graf
2013-04-04 16:41 ` Peter Maydell
2013-04-04 16:51 ` Alexander Graf
2013-04-04 16:52 ` Peter Maydell
2013-04-04 22:32 ` Alexander Graf
2013-04-04 22:35 ` Peter Maydell
2013-04-04 16:46 ` Artyom Tarasenko
2013-04-04 16:51 ` Peter Maydell
2013-04-04 17:08 ` Artyom Tarasenko
2013-04-04 17:22 ` Andreas Färber
2013-04-05 9:19 ` Fabien Chouteau
2013-04-05 9:30 ` Peter Maydell
2013-04-04 17:05 ` Andreas Färber
2013-04-05 2:32 ` Rob Landley
2013-04-04 11:16 ` Andreas Färber
2013-04-04 16:18 ` Fabien Chouteau
2013-04-03 16:47 ` [Qemu-devel] [PATCH 0/3] PPC PReP: Use ElF kernel on PReP Alexander Graf
2013-04-03 17:32 ` Andreas Färber
2013-04-04 8:17 ` Fabien Chouteau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365007213-27603-4-git-send-email-chouteau@adacore.com \
--to=chouteau@adacore.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).