qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	patches@linaro.org, "Will Deacon" <will.deacon@arm.com>,
	"Paul Brook" <paul@codesourcery.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH v3 09/11] arm/realview: Fix mapping of PCI regions
Date: Thu,  4 Apr 2013 13:58:31 +0100	[thread overview]
Message-ID: <1365080313-20875-10-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1365080313-20875-1-git-send-email-peter.maydell@linaro.org>

Fix the mapping of the PCI regions for the realview board, which were
all incorrect. (This was never noticed because the Linux kernel
doesn't actually include a PCI driver for the realview boards.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Paul Brook <paul@codesourcery.com>
---
 hw/arm/realview.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index ba61d18..23c968b 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -218,9 +218,9 @@ static void realview_init(QEMUMachineInitArgs *args,
         busdev = SYS_BUS_DEVICE(dev);
         qdev_init_nofail(dev);
         sysbus_mmio_map(busdev, 0, 0x10019000); /* PCI controller registers */
-        sysbus_mmio_map(busdev, 1, 0x61000000); /* PCI self-config */
-        sysbus_mmio_map(busdev, 2, 0x62000000); /* PCI config */
-        sysbus_mmio_map(busdev, 3, 0x63000000); /* PCI I/O */
+        sysbus_mmio_map(busdev, 1, 0x60000000); /* PCI self-config */
+        sysbus_mmio_map(busdev, 2, 0x61000000); /* PCI config */
+        sysbus_mmio_map(busdev, 3, 0x62000000); /* PCI I/O */
         sysbus_connect_irq(busdev, 0, pic[48]);
         sysbus_connect_irq(busdev, 1, pic[49]);
         sysbus_connect_irq(busdev, 2, pic[50]);
@@ -304,12 +304,12 @@ static void realview_init(QEMUMachineInitArgs *args,
     /*  0x58000000 PISMO.  */
     /*  0x5c000000 PISMO.  */
     /* 0x60000000 PCI.  */
-    /* 0x61000000 PCI Self Config.  */
-    /* 0x62000000 PCI Config.  */
-    /* 0x63000000 PCI IO.  */
-    /* 0x64000000 PCI mem 0.  */
-    /* 0x68000000 PCI mem 1.  */
-    /* 0x6c000000 PCI mem 2.  */
+    /* 0x60000000 PCI Self Config.  */
+    /* 0x61000000 PCI Config.  */
+    /* 0x62000000 PCI IO.  */
+    /* 0x63000000 PCI mem 0.  */
+    /* 0x64000000 PCI mem 1.  */
+    /* 0x68000000 PCI mem 2.  */
 
     /* ??? Hack to map an additional page of ram for the secondary CPU
        startup code.  I guess this works on real hardware because the
-- 
1.7.9.5

  parent reply	other threads:[~2013-04-04 12:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 12:58 [Qemu-devel] [PATCH v3 00/11] Fix versatile_pci (without breaking linux) Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 01/11] versatile_pci: Fix hardcoded tabs Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 02/11] versatile_pci: Expose PCI I/O region on Versatile PB Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 03/11] versatile_pci: Update to realize and instance init functions Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 04/11] versatile_pci: Change to subclassing TYPE_PCI_HOST_BRIDGE Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 05/11] versatile_pci: Use separate PCI I/O space rather than system I/O space Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 06/11] versatile_pci: Put the host bridge PCI device at slot 29 Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 07/11] versatile_pci: Implement the correct PCI IRQ mapping Peter Maydell
2013-04-04 17:03   ` Michael S. Tsirkin
2013-04-04 19:47     ` Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 08/11] versatile_pci: Implement the PCI controller's control registers Peter Maydell
2013-04-04 12:58 ` Peter Maydell [this message]
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 10/11] versatile_pci: Expose PCI memory space to system Peter Maydell
2013-04-04 12:58 ` [Qemu-devel] [PATCH v3 11/11] hw/versatile_pci: Drop unnecessary vpb_pci_config_addr() Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365080313-20875-10-git-send-email-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=arnd@arndb.de \
    --cc=aurelien@aurel32.net \
    --cc=mst@redhat.com \
    --cc=patches@linaro.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).