From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNodC-00014m-7h for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNodB-0000AV-1q for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNodA-0000AI-RK for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:24 -0400 From: Eduardo Habkost Date: Thu, 4 Apr 2013 15:11:09 -0300 Message-Id: <1365099073-21491-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1365099073-21491-1-git-send-email-ehabkost@redhat.com> References: <1365099073-21491-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 1/5] target-i386: Add ECX information to FeatureWordInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , =?UTF-8?q?Andreas=20F=C3=A4rber?= FEAT_7_0_EBX uses ECX as input, so we have to take that into account when reporting feature word values. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index df6d6f0..6bb228b 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -151,8 +151,10 @@ static const char *cpuid_7_0_ebx_feature_name[] = { typedef struct FeatureWordInfo { const char **feat_names; - uint32_t cpuid_eax; /* Input EAX for CPUID */ - int cpuid_reg; /* R_* register constant */ + uint32_t cpuid_eax; /* Input EAX for CPUID */ + bool cpuid_needs_ecx; /* CPUID instruction uses ECX as input */ + uint32_t cpuid_ecx; /* Input ECX value for CPUID */ + int cpuid_reg; /* output register (R_* constant) */ } FeatureWordInfo; static FeatureWordInfo feature_word_info[FEATURE_WORDS] = { @@ -186,7 +188,9 @@ static FeatureWordInfo feature_word_info[FEATURE_WORDS] = { }, [FEAT_7_0_EBX] = { .feat_names = cpuid_7_0_ebx_feature_name, - .cpuid_eax = 7, .cpuid_reg = R_EBX, + .cpuid_eax = 7, + .cpuid_needs_ecx = true, .cpuid_ecx = 0, + .cpuid_reg = R_EBX, }, }; -- 1.8.1.4