From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNodF-00014z-Bo for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNodE-0000Bk-6o for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNodD-0000BL-UZ for qemu-devel@nongnu.org; Thu, 04 Apr 2013 14:11:28 -0400 From: Eduardo Habkost Date: Thu, 4 Apr 2013 15:11:11 -0300 Message-Id: <1365099073-21491-4-git-send-email-ehabkost@redhat.com> In-Reply-To: <1365099073-21491-1-git-send-email-ehabkost@redhat.com> References: <1365099073-21491-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [RFC 3/5] target-i386: Use FeatureWord loop on filter_features_for_kvm() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , =?UTF-8?q?Andreas=20F=C3=A4rber?= Instead of open-coding the filtering code for each feature word, change the existing code to use the feature_word_info array, that have exactly the same CPUID eax/ecx/register values for each feature word. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 75ffc9e..3f4bcfd 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1637,24 +1637,14 @@ static void filter_features_for_kvm(X86CPU *cpu) { CPUX86State *env = &cpu->env; KVMState *s = kvm_state; + FeatureWord w; - env->features[FEAT_1_EDX] &= - kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX); - env->features[FEAT_1_ECX] &= - kvm_arch_get_supported_cpuid(s, 1, 0, R_ECX); - env->features[FEAT_8000_0001_EDX] &= - kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_EDX); - env->features[FEAT_8000_0001_ECX] &= - kvm_arch_get_supported_cpuid(s, 0x80000001, 0, R_ECX); - env->features[FEAT_SVM] &= - kvm_arch_get_supported_cpuid(s, 0x8000000A, 0, R_EDX); - env->features[FEAT_7_0_EBX] &= - kvm_arch_get_supported_cpuid(s, 7, 0, R_EBX); - env->features[FEAT_KVM] &= - kvm_arch_get_supported_cpuid(s, KVM_CPUID_FEATURES, 0, R_EAX); - env->features[FEAT_C000_0001_EDX] &= - kvm_arch_get_supported_cpuid(s, 0xC0000001, 0, R_EDX); - + for (w = 0; w < FEATURE_WORDS; w++) { + FeatureWordInfo *wi = &feature_word_info[w]; + env->features[w] &= kvm_arch_get_supported_cpuid(s, wi->cpuid_eax, + wi->cpuid_ecx, + wi->cpuid_reg); + } } #endif -- 1.8.1.4