From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNt5j-0005bd-5v for qemu-devel@nongnu.org; Thu, 04 Apr 2013 18:57:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNt5b-0001Hy-UU for qemu-devel@nongnu.org; Thu, 04 Apr 2013 18:57:11 -0400 Received: from mail-ob0-x233.google.com ([2607:f8b0:4003:c01::233]:64448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNt5b-0001Hq-LW for qemu-devel@nongnu.org; Thu, 04 Apr 2013 18:57:03 -0400 Received: by mail-ob0-f179.google.com with SMTP id vb8so3150966obc.10 for ; Thu, 04 Apr 2013 15:57:03 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 4 Apr 2013 17:56:02 -0500 Message-Id: <1365116186-19382-10-git-send-email-rth@twiddle.net> In-Reply-To: <1365116186-19382-1-git-send-email-rth@twiddle.net> References: <1365116186-19382-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v4 09/33] tcg-ppc64: Cleanup tcg_out_movi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: av1474@comtv.ru, Aurelien Jarno The test for using movi32 was sub-optimal for TCG_TYPE_I32, comparing a signed 32-bit quantity against an unsigned 32-bit quantity. When possible, use addi+oris for 32-bit unsigned constants. Otherwise, standardize on addi+oris+ori instead of addis+ori+rldicl. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 41 +++++++++++++++++------------------------ 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 822eb07..c6ff75b 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -480,32 +480,25 @@ static void tcg_out_movi32(TCGContext *s, TCGReg ret, int32_t arg) } } -static void tcg_out_movi (TCGContext *s, TCGType type, - TCGReg ret, tcg_target_long arg) +static void tcg_out_movi(TCGContext *s, TCGType type, TCGReg ret, + tcg_target_long arg) { - int32_t arg32 = arg; - arg = type == TCG_TYPE_I32 ? arg & 0xffffffff : arg; - - if (arg == arg32) { - tcg_out_movi32 (s, ret, arg32); - } - else { - if ((uint64_t) arg >> 32) { - uint16_t h16 = arg >> 16; - uint16_t l16 = arg; - - tcg_out_movi32(s, ret, arg >> 32); + if (type == TCG_TYPE_I32 || arg == (int32_t)arg) { + tcg_out_movi32(s, ret, arg); + } else if (arg == (uint32_t)arg && !(arg & 0x8000)) { + tcg_out32(s, ADDI | TAI(ret, 0, arg)); + tcg_out32(s, ORIS | SAI(ret, ret, arg >> 16)); + } else { + int32_t high = arg >> 32; + tcg_out_movi32(s, ret, high); + if (high) { tcg_out_shli64(s, ret, ret, 32); - if (h16) { - tcg_out32(s, ORIS | SAI(ret, ret, h16)); - } - if (l16) { - tcg_out32(s, ORI | SAI(ret, ret, l16)); - } - } else { - tcg_out_movi32 (s, ret, arg32); - if (arg32 < 0) - tcg_out_ext32u(s, ret, ret); + } + if (arg & 0xffff0000) { + tcg_out32(s, ORIS | SAI(ret, ret, arg >> 16)); + } + if (arg & 0xffff) { + tcg_out32(s, ORI | SAI(ret, ret, arg)); } } } -- 1.8.1.4