qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 6/8] block: clean up I/O throttling wait_time code
Date: Fri,  5 Apr 2013 15:28:08 +0200	[thread overview]
Message-ID: <1365168490-29616-7-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1365168490-29616-1-git-send-email-kwolf@redhat.com>

From: Stefan Hajnoczi <stefanha@redhat.com>

The wait_time variable is in seconds.  Reflect this in a comment and use
NANOSECONDS_PER_SECOND instead of BLOCK_IO_SLICE_TIME * 10 (which
happens to have the right value).

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Tested-By: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/block.c b/block.c
index aa16fc4..602d8a4 100644
--- a/block.c
+++ b/block.c
@@ -3800,7 +3800,7 @@ static bool bdrv_exceed_bps_limits(BlockDriverState *bs, int nb_sectors,
                 BLOCK_IO_SLICE_TIME;
     bs->slice_end += extension;
     if (wait) {
-        *wait = wait_time * BLOCK_IO_SLICE_TIME * 10;
+        *wait = wait_time * NANOSECONDS_PER_SECOND;
     }
 
     return true;
@@ -3841,7 +3841,7 @@ static bool bdrv_exceed_iops_limits(BlockDriverState *bs, bool is_write,
         return false;
     }
 
-    /* Calc approx time to dispatch */
+    /* Calc approx time to dispatch, in seconds */
     wait_time = (ios_base + 1) / iops_limit;
     if (wait_time > elapsed_time) {
         wait_time = wait_time - elapsed_time;
@@ -3852,7 +3852,7 @@ static bool bdrv_exceed_iops_limits(BlockDriverState *bs, bool is_write,
     /* Exceeded current slice, extend it by another slice time */
     bs->slice_end += BLOCK_IO_SLICE_TIME;
     if (wait) {
-        *wait = wait_time * BLOCK_IO_SLICE_TIME * 10;
+        *wait = wait_time * NANOSECONDS_PER_SECOND;
     }
 
     return true;
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-05 13:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 13:28 [Qemu-devel] [PULL 0/8] Block patches Kevin Wolf
2013-04-05 13:28 ` [Qemu-devel] [PATCH 1/8] virtio-blk-x: fix configuration synchronization Kevin Wolf
2013-04-05 16:47   ` Anthony Liguori
2013-04-05 17:56     ` Peter Maydell
2013-04-05 19:24       ` Anthony Liguori
2013-04-06 19:31         ` KONRAD Frédéric
2013-04-05 13:28 ` [Qemu-devel] [PATCH 2/8] usb-storage: Forward serial number to scsi-disk Kevin Wolf
2013-04-05 13:28 ` [Qemu-devel] [PATCH 3/8] block: fix I/O throttling accounting blind spot Kevin Wolf
2013-04-05 13:28 ` [Qemu-devel] [PATCH 4/8] block: keep I/O throttling slice time constant Kevin Wolf
2013-04-05 13:28 ` [Qemu-devel] [PATCH 5/8] block: drop duplicated slice extension code Kevin Wolf
2013-04-05 13:28 ` Kevin Wolf [this message]
2013-04-05 13:28 ` [Qemu-devel] [PATCH 7/8] qcow2: Return real error in qcow2_update_snapshot_refcount Kevin Wolf
2013-04-05 13:28 ` [Qemu-devel] [PATCH 8/8] qcow2: Fix L1 write error handling " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365168490-29616-7-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).