qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 2/5] linux-user: Don't omit comma for strace of rt_sigaction()
Date: Fri,  5 Apr 2013 16:08:43 +0200	[thread overview]
Message-ID: <1365170926-6361-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1365170926-6361-1-git-send-email-stefanha@redhat.com>

From: Peter Maydell <peter.maydell@linaro.org>

Pass the 'last' parameter of print_signal() through to
print_raw_param(); this fixes a problem where we weren't printing
the comma separator for strace of rt_sigaction() when the signal
was an unnamed (ie realtime) one:
  6856 rt_sigaction(230xf6fff870,0xf6fff8fc) = 0

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 linux-user/strace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 0fbae3c..ea6c1d2 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -143,7 +143,7 @@ print_signal(abi_ulong arg, int last)
     case TARGET_SIGTTOU: signal_name = "SIGTTOU"; break;
     }
     if (signal_name == NULL) {
-        print_raw_param("%ld", arg, 1);
+        print_raw_param("%ld", arg, last);
         return;
     }
     gemu_log("%s%s", signal_name, get_comma(last));
-- 
1.8.1.4

  parent reply	other threads:[~2013-04-05 14:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-05 14:08 [Qemu-devel] [PULL 0/5] Trivial patches for 28 March to 5 April 2013 Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 1/5] test-visitor-serialization: Fix some memory leaks Stefan Hajnoczi
2013-04-05 14:08 ` Stefan Hajnoczi [this message]
2013-04-05 14:08 ` [Qemu-devel] [PATCH 3/5] target-s390: Fix SRNMT Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 4/5] petalogix_ml605_mmu: Cleanup ssi_create_slave() Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 5/5] xilinx_zynq: Cleanup ssi_create_slave Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365170926-6361-3-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).