From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 5/5] xilinx_zynq: Cleanup ssi_create_slave
Date: Fri, 5 Apr 2013 16:08:46 +0200 [thread overview]
Message-ID: <1365170926-6361-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1365170926-6361-1-git-send-email-stefanha@redhat.com>
From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
With the recent m25p80 cleanup there is no need to use
ssi_create_slave_no_init() anymore. Just use ssi_create_slave().
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/arm/xilinx_zynq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 6f36286..5b9257a 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -86,8 +86,7 @@ static inline void zynq_init_spi_flashes(uint32_t base_addr, qemu_irq irq,
spi = (SSIBus *)qdev_get_child_bus(dev, bus_name);
for (j = 0; j < num_ss; ++j) {
- flash_dev = ssi_create_slave_no_init(spi, "n25q128");
- qdev_init_nofail(flash_dev);
+ flash_dev = ssi_create_slave(spi, "n25q128");
cs_line = qdev_get_gpio_in(flash_dev, 0);
sysbus_connect_irq(busdev, i * num_ss + j + 1, cs_line);
--
1.8.1.4
prev parent reply other threads:[~2013-04-05 14:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-05 14:08 [Qemu-devel] [PULL 0/5] Trivial patches for 28 March to 5 April 2013 Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 1/5] test-visitor-serialization: Fix some memory leaks Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 2/5] linux-user: Don't omit comma for strace of rt_sigaction() Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 3/5] target-s390: Fix SRNMT Stefan Hajnoczi
2013-04-05 14:08 ` [Qemu-devel] [PATCH 4/5] petalogix_ml605_mmu: Cleanup ssi_create_slave() Stefan Hajnoczi
2013-04-05 14:08 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365170926-6361-6-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).