From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPAH4-0007T8-Ts for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:30:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPAGy-0006Y2-U8 for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:30:10 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:34611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPAGy-0006Vv-OK for qemu-devel@nongnu.org; Mon, 08 Apr 2013 07:30:04 -0400 Received: by mail-we0-f172.google.com with SMTP id r3so4477417wey.3 for ; Mon, 08 Apr 2013 04:30:04 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 8 Apr 2013 13:29:54 +0200 Message-Id: <1365420597-5506-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1365420597-5506-1-git-send-email-pbonzini@redhat.com> References: <1365420597-5506-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/4] migration: set f->is_write and flush in add_to_iovec List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, owasserm@redhat.com, quintela@redhat.com Signed-off-by: Paolo Bonzini --- savevm.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/savevm.c b/savevm.c index b1d8988..c952c41 100644 --- a/savevm.c +++ b/savevm.c @@ -631,6 +631,11 @@ static void add_to_iovec(QEMUFile *f, const uint8_t *buf, int size) f->iov[f->iovcnt].iov_base = (uint8_t *)buf; f->iov[f->iovcnt++].iov_len = size; } + + f->is_write = 1; + if (f->buf_index >= IO_BUF_SIZE || f->iovcnt >= MAX_IOV_SIZE) { + qemu_fflush(f); + } } void qemu_put_buffer_async(QEMUFile *f, const uint8_t *buf, int size) @@ -645,14 +650,8 @@ void qemu_put_buffer_async(QEMUFile *f, const uint8_t *buf, int size) abort(); } - add_to_iovec(f, buf, size); - - f->is_write = 1; f->bytes_xfer += size; - - if (f->buf_index >= IO_BUF_SIZE || f->iovcnt >= MAX_IOV_SIZE) { - qemu_fflush(f); - } + add_to_iovec(f, buf, size); } void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size) @@ -674,7 +673,6 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size) if (l > size) l = size; memcpy(f->buf + f->buf_index, buf, l); - f->is_write = 1; f->buf_index += l; qemu_put_buffer_async(f, f->buf + (f->buf_index - l), l); if (qemu_file_get_error(f)) { @@ -697,15 +695,10 @@ void qemu_put_byte(QEMUFile *f, int v) abort(); } - f->buf[f->buf_index++] = v; - f->is_write = 1; + f->buf[f->buf_index] = v; f->bytes_xfer++; - - add_to_iovec(f, f->buf + (f->buf_index - 1), 1); - - if (f->buf_index >= IO_BUF_SIZE || f->iovcnt >= MAX_IOV_SIZE) { - qemu_fflush(f); - } + add_to_iovec(f, f->buf + f->buf_index, 1); + f->buf_index++; } static void qemu_file_skip(QEMUFile *f, int size) -- 1.8.2