From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPEEq-000194-Ke for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:44:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPEEk-0000eD-Cu for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:44:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPEEk-0000dy-4N for qemu-devel@nongnu.org; Mon, 08 Apr 2013 11:44:02 -0400 From: Stefan Hajnoczi Date: Mon, 8 Apr 2013 17:43:49 +0200 Message-Id: <1365435829-23535-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1365435829-23535-1-git-send-email-stefanha@redhat.com> References: <1365435829-23535-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/2] vmxnet3: const_cpu_to_le64 wrapping for feature bits dropped List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Anthony Liguori , Stefan Hajnoczi From: Dmitry Fleytman Byte swap is redundant because shared memory reading functions already swap bytes when required Signed-off-by: Dmitry Fleytman Acked-by: Alexander Graf Signed-off-by: Stefan Hajnoczi --- hw/vmxnet3.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/vmxnet3.h b/hw/vmxnet3.h index 7db0c8f..4eae7c7 100644 --- a/hw/vmxnet3.h +++ b/hw/vmxnet3.h @@ -37,10 +37,8 @@ #define __packed QEMU_PACKED #if defined(HOST_WORDS_BIGENDIAN) -#define const_cpu_to_le64(x) bswap_64(x) #define __BIG_ENDIAN_BITFIELD #else -#define const_cpu_to_le64(x) (x) #endif /* @@ -137,10 +135,10 @@ struct UPT1_RSSConf { /* features */ enum { - UPT1_F_RXCSUM = const_cpu_to_le64(0x0001), /* rx csum verification */ - UPT1_F_RSS = const_cpu_to_le64(0x0002), - UPT1_F_RXVLAN = const_cpu_to_le64(0x0004), /* VLAN tag stripping */ - UPT1_F_LRO = const_cpu_to_le64(0x0008), + UPT1_F_RXCSUM = 0x0001, /* rx csum verification */ + UPT1_F_RSS = 0x0002, + UPT1_F_RXVLAN = 0x0004, /* VLAN tag stripping */ + UPT1_F_LRO = 0x0008, }; /* all registers are 32 bit wide */ @@ -752,7 +750,6 @@ struct Vmxnet3_DriverShared { #undef __le32 #undef __le64 #undef __packed -#undef const_cpu_to_le64 #if defined(HOST_WORDS_BIGENDIAN) #undef __BIG_ENDIAN_BITFIELD #endif -- 1.8.1.4