From: liguang <lig.fnst@cn.fujitsu.com>
To: afaerber@suse.de, qemu-devel@nongnu.org
Cc: liguang <lig.fnst@cn.fujitsu.com>
Subject: [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback
Date: Wed, 10 Apr 2013 16:02:28 +0800 [thread overview]
Message-ID: <1365580949-32467-1-git-send-email-lig.fnst@cn.fujitsu.com> (raw)
we should remove it now, if not, cpu reset
will do 2 times.
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
target-i386/cpu.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 356378c..6e13053 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2024,13 +2024,6 @@ bool cpu_is_bsp(X86CPU *cpu)
{
return cpu_get_apic_base(cpu->env.apic_state) & MSR_IA32_APICBASE_BSP;
}
-
-/* TODO: remove me, when reset over QOM tree is implemented */
-static void x86_cpu_machine_reset_cb(void *opaque)
-{
- X86CPU *cpu = opaque;
- cpu_reset(CPU(cpu));
-}
#endif
static void mce_init(X86CPU *cpu)
@@ -2140,8 +2133,6 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
}
#ifndef CONFIG_USER_ONLY
- qemu_register_reset(x86_cpu_machine_reset_cb, cpu);
-
if (cpu->env.cpuid_features & CPUID_APIC || smp_cpus > 1) {
x86_cpu_apic_init(cpu, &local_err);
if (local_err != NULL) {
--
1.7.2.5
next reply other threads:[~2013-04-10 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 8:02 liguang [this message]
2013-04-10 8:02 ` [Qemu-devel] [PATCH 2/2] target-i386: fix 2 malformed indents liguang
2013-04-10 8:34 ` [Qemu-devel] [PATCH 1/2] target-i386: remove cpu reset callback Igor Mammedov
2013-04-10 8:52 ` li guang
2013-04-10 9:03 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365580949-32467-1-git-send-email-lig.fnst@cn.fujitsu.com \
--to=lig.fnst@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).