From: "Benoît Canet" <benoit@irqsave.net>
To: qemu-devel@nongnu.org
Cc: "Benoît Canet" <benoit@irqsave.net>,
aneesh.kumar@linux.vnet.ibm.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 4/4] virtio-9p: Remove migration blockers.
Date: Thu, 11 Apr 2013 14:14:28 +0200 [thread overview]
Message-ID: <1365682468-12301-5-git-send-email-benoit@irqsave.net> (raw)
In-Reply-To: <1365682468-12301-1-git-send-email-benoit@irqsave.net>
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
hw/9pfs/virtio-9p-device.c | 2 --
hw/9pfs/virtio-9p.c | 23 -----------------------
hw/9pfs/virtio-9p.h | 2 --
3 files changed, 27 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index 02b8630..f91a9b8 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -86,7 +86,6 @@ static void virtio_9p_save(QEMUFile *f, void *opaque)
qemu_put_be32(f, s->proto_version);
qemu_put_be32(f, s->msize);
- qemu_put_be32(f, s->root_fid);
}
static void virtio_9p_load_path(QEMUFile *f, V9fsPath *path)
@@ -160,7 +159,6 @@ static int virtio_9p_load(QEMUFile *f, void *opaque, int version_id)
s->proto_version = qemu_get_be32(f);
s->msize = qemu_get_be32(f);
- s->root_fid = qemu_get_be32(f);
return 0;
}
diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c
index 3bf3ee4..b46924f 100644
--- a/hw/9pfs/virtio-9p.c
+++ b/hw/9pfs/virtio-9p.c
@@ -399,19 +399,6 @@ static int put_fid(V9fsPDU *pdu, V9fsFidState *fidp)
* Don't free the fid if it is in reclaim list
*/
if (!fidp->ref && fidp->clunked) {
- if (fidp->fid == pdu->s->root_fid) {
- /*
- * if the clunked fid is root fid then we
- * have unmounted the fs on the client side.
- * delete the migration blocker. Ideally, this
- * should be hooked to transport close notification
- */
- if (pdu->s->migration_blocker) {
- migrate_del_blocker(pdu->s->migration_blocker);
- error_free(pdu->s->migration_blocker);
- pdu->s->migration_blocker = NULL;
- }
- }
return free_fid(pdu, fidp);
}
return 0;
@@ -1048,16 +1035,6 @@ static void v9fs_attach(void *opaque)
err += offset;
trace_v9fs_attach_return(pdu->tag, pdu->id,
qid.type, qid.version, qid.path);
- /*
- * disable migration if we haven't done already.
- * attach could get called multiple times for the same export.
- */
- if (!s->migration_blocker) {
- s->root_fid = fid;
- error_set(&s->migration_blocker, QERR_VIRTFS_FEATURE_BLOCKS_MIGRATION,
- s->ctx.fs_root ? s->ctx.fs_root : "NULL", s->tag);
- migrate_add_blocker(s->migration_blocker);
- }
out:
put_fid(pdu, fidp);
out_nofid:
diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h
index 4d16d46..94d6f76 100644
--- a/hw/9pfs/virtio-9p.h
+++ b/hw/9pfs/virtio-9p.h
@@ -223,8 +223,6 @@ typedef struct V9fsState
* on rename.
*/
CoRwlock rename_lock;
- int32_t root_fid;
- Error *migration_blocker;
} V9fsState;
typedef struct V9fsStatState {
--
1.7.10.4
next prev parent reply other threads:[~2013-04-11 12:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 12:14 [Qemu-devel] [PATCH 0/4] Virtio-9p live migration patchset Benoît Canet
2013-04-11 12:14 ` [Qemu-devel] [PATCH 1/4] migration: Create the pre migration flush hook infrastructure Benoît Canet
2013-04-11 12:16 ` Peter Maydell
2013-04-11 12:34 ` Paolo Bonzini
2013-04-11 12:14 ` [Qemu-devel] [PATCH 2/4] virtio-9p: Add support for 9p migration Benoît Canet
2013-04-11 12:14 ` [Qemu-devel] [PATCH 3/4] virtio-9p: Wait for 9p operations to complete before migration Benoît Canet
2013-04-11 12:38 ` Paolo Bonzini
2013-04-11 12:41 ` Peter Maydell
2013-04-11 12:14 ` Benoît Canet [this message]
2013-04-11 12:18 ` [Qemu-devel] [PATCH 4/4] virtio-9p: Remove migration blockers Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365682468-12301-5-git-send-email-benoit@irqsave.net \
--to=benoit@irqsave.net \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).