qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, ehabkost@redhat.com,
	claudio.fontana@huawei.com, aderumier@odiso.com,
	lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com,
	yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de,
	lig.fnst@cn.fujitsu.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists
Date: Thu, 11 Apr 2013 16:51:48 +0200	[thread overview]
Message-ID: <1365691918-30594-10-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1365691918-30594-1-git-send-email-imammedo@redhat.com>

... it should be used only on slow path since it does recursive search
    on /machine QOM tree for objects of TYPE_CPU

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
v2:
  * s/get_firmware_id()/get_arch_id()/ rebase fixup
  * remove check for get_arch_id being NULL, since it's always defined
---
 include/qom/cpu.h | 10 ++++++++++
 qom/cpu.c         | 21 +++++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index b376416..cd7c4b5 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -225,6 +225,16 @@ void run_on_cpu(CPUState *cpu, void (*func)(void *data), void *data);
  */
 CPUState *qemu_get_cpu(int index);
 
+/**
+ * cpu_exists:
+ * @id - guest exposed CPU ID to lookup
+ *
+ * Search for CPU with specified ID.
+ *
+ * Returns: true - CPU is found, false - CPU isn't found
+ */
+bool cpu_exists(int64_t id);
+
 #ifndef CONFIG_USER_ONLY
 
 typedef void (*CPUInterruptHandler)(CPUState *, int);
diff --git a/qom/cpu.c b/qom/cpu.c
index 90cbd77..c850d27 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -25,6 +25,27 @@
 #include "qemu/notify.h"
 #include "sysemu/sysemu.h"
 
+static int cpu_exist_cb(Object *obj, void *opaque)
+{
+    int64_t id = *(int64_t *)opaque;
+    Object *cpu_obj = object_dynamic_cast(obj, TYPE_CPU);
+
+    if (cpu_obj) {
+        CPUState *cpu = CPU(cpu_obj);
+        CPUClass *klass = CPU_GET_CLASS(cpu);
+
+        if (klass->get_arch_id(cpu) == id) {
+            return 1;
+        }
+    }
+    return object_child_foreach(obj, cpu_exist_cb, opaque);
+}
+
+bool cpu_exists(int64_t id)
+{
+   return cpu_exist_cb(qdev_get_machine(), &id) ? true : false;
+}
+
 /* CPU hot-plug notifiers */
 static NotifierList cpu_added_notifiers =
     NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers);
-- 
1.8.2

  parent reply	other threads:[~2013-04-11 14:52 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-11 14:51 [Qemu-devel] [PATCH 00/19 v3] target-i386: CPU hot-add with cpu-add QMP command Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 01/19] target-i386: split out CPU creation and features parsing into cpu_x86_create() Igor Mammedov
2013-04-11 17:03   ` Eduardo Habkost
2013-04-15 15:03   ` Andreas Färber
2013-04-11 14:51 ` [Qemu-devel] [PATCH 02/19] cpu: Pass CPUState to *cpu_synchronize_post*() Igor Mammedov
2013-04-15 15:12   ` Andreas Färber
2013-04-11 14:51 ` [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library Igor Mammedov
2013-04-11 17:45   ` Eduardo Habkost
2013-04-12 11:17     ` Igor Mammedov
2013-04-12 19:25       ` Eduardo Habkost
2013-04-15  9:09         ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged Igor Mammedov
2013-04-11 18:33   ` Eduardo Habkost
2013-04-12 11:34     ` Igor Mammedov
2013-04-12 14:08       ` Eduardo Habkost
2013-04-15 19:57   ` Eduardo Habkost
2013-04-15 20:21     ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 05/19] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged Igor Mammedov
2013-04-11 18:36   ` Eduardo Habkost
2013-04-12 11:36     ` Igor Mammedov
2013-04-15 19:58   ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier Igor Mammedov
2013-04-11 18:46   ` Eduardo Habkost
2013-04-12 11:00     ` Igor Mammedov
2013-04-15 20:08       ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug Igor Mammedov
2013-04-11 18:59   ` Eduardo Habkost
2013-04-12 10:53     ` Igor Mammedov
2013-04-12 13:35       ` Eduardo Habkost
2013-04-12 15:16         ` Igor Mammedov
2013-04-12 15:35           ` Eduardo Habkost
2013-04-12 16:24             ` Igor Mammedov
2013-04-15  9:38               ` Igor Mammedov
2013-04-15 17:53                 ` Eduardo Habkost
2013-04-11 14:51 ` [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386 Igor Mammedov
2013-04-11 19:04   ` Eduardo Habkost
2013-04-12 10:31     ` Igor Mammedov
2013-04-12 13:47       ` Eduardo Habkost
2013-04-15 15:24   ` Andreas Färber
2013-04-15 15:34     ` Igor Mammedov
2013-04-15 15:42       ` Andreas Färber
2013-04-15 15:47     ` Eduardo Habkost
2013-04-15 20:34       ` Igor Mammedov
2013-04-11 14:51 ` Igor Mammedov [this message]
2013-04-11 19:06   ` [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists Eduardo Habkost
2013-04-12 10:14     ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 10/19] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property Igor Mammedov
2013-04-11 19:12   ` Eduardo Habkost
2013-04-12 10:20     ` Igor Mammedov
2013-04-12 13:13       ` Eduardo Habkost
2013-04-12 15:46         ` Igor Mammedov
2013-04-12 16:29           ` Eduardo Habkost
2013-04-15  2:30             ` li guang
2013-04-15 13:37             ` Igor Mammedov
2013-04-15 13:45               ` Eduardo Habkost
2013-04-15 14:34                 ` Igor Mammedov
2013-04-15 14:49                   ` Eduardo Habkost
2013-04-15 20:27                     ` Igor Mammedov
2013-04-15 20:49                       ` Eduardo Habkost
2013-04-15 21:13                         ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 12/19] introduce ICC bus/device/bridge Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 13/19] target-i386: cpu: attach ICC bus to CPU on its creation Igor Mammedov
2013-04-15 15:38   ` Andreas Färber
2013-04-15 15:49     ` Igor Mammedov
2013-04-15 16:06       ` Andreas Färber
2013-04-15 16:17         ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 14/19] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE Igor Mammedov
2013-04-15 15:34   ` Andreas Färber
2013-04-15 15:47     ` Jan Kiszka
2013-04-11 14:51 ` [Qemu-devel] [PATCH 15/19] target-i386: move APIC to ICC bus Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 16/19] target-i386: move IOAPIC " Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 17/19] qdev: set device's parent before calling realize() down inheritance chain Igor Mammedov
2013-04-15 15:48   ` Andreas Färber
2013-04-11 14:51 ` [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links Igor Mammedov
2013-04-11 17:19   ` Eduardo Habkost
2013-04-12 10:01     ` Igor Mammedov
2013-04-12 12:44       ` Eduardo Habkost
2013-04-15 14:15         ` Igor Mammedov
2013-04-15 14:48           ` Eduardo Habkost
2013-04-15 15:16             ` Igor Mammedov
2013-04-15 15:26               ` Eduardo Habkost
2013-04-15 20:37                 ` Igor Mammedov
2013-04-11 14:51 ` [Qemu-devel] [PATCH 19/19] add cpu-add qmp command and implement CPU hot-add for target-i386 Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1365691918-30594-10-git-send-email-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=aderumier@odiso.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=claudio.fontana@huawei.com \
    --cc=ehabkost@redhat.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).