From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJkQ-00086m-9o for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:49:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJkN-00049n-77 for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:49:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJkM-00049e-Vi for qemu-devel@nongnu.org; Thu, 11 Apr 2013 11:49:11 -0400 From: Stefan Hajnoczi Date: Thu, 11 Apr 2013 17:44:34 +0200 Message-Id: <1365695085-27970-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1365695085-27970-1-git-send-email-stefanha@redhat.com> References: <1365695085-27970-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [RFC 02/13] dataplane/virtio-blk: check exit conditions before aio_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Anthony Liguori , pingfank@linux.vnet.ibm.com Check exit conditions before entering blocking aio_poll(). This is mainly for consistency since it's unlikely that we are stopping in the first event loop iteration. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index 5baef23..982896c 100644 --- a/hw/block/dataplane/virtio-blk.c +++ b/hw/block/dataplane/virtio-blk.c @@ -378,9 +378,9 @@ static void *data_plane_thread(void *opaque) { VirtIOBlockDataPlane *s = opaque; - do { + while (!s->stopping || s->num_reqs > 0) { aio_poll(s->ctx, true); - } while (!s->stopping || s->num_reqs > 0); + } return NULL; } -- 1.8.1.4