From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQSzf-0007bJ-Um for qemu-devel@nongnu.org; Thu, 11 Apr 2013 21:41:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQSze-0002nc-RF for qemu-devel@nongnu.org; Thu, 11 Apr 2013 21:41:35 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:42491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQSze-0002mO-LH for qemu-devel@nongnu.org; Thu, 11 Apr 2013 21:41:34 -0400 Received: by mail-pb0-f45.google.com with SMTP id ro12so1154290pbb.4 for ; Thu, 11 Apr 2013 18:41:32 -0700 (PDT) From: Alexey Kardashevskiy Date: Fri, 12 Apr 2013 11:41:15 +1000 Message-Id: <1365730875-22854-1-git-send-email-aik@ozlabs.ru> Subject: [Qemu-devel] [PATCH] bswap: fix compiler warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Alexey Kardashevskiy , Blue Swirl , Paolo Bonzini , Richard Henderson , David Gibson The bswap functions use memcpy but the bswap.h header itself does not seem to include it in some configuration such as cross compiling for powerpc64 on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC18/ppc64), the example warning is below. The patch explicitly includes string.h. CC ppc64-softmmu/hw/virtio/virtio.o In file included from /home/alexey/qemu/include/libfdt_env.h:22:0, from /home/alexey/qemu/../lib4qemu/usr/include/libfdt.h:54, from /home/alexey/qemu/hw/nvram/spapr_nvram.c:25: /home/alexey/qemu/include/qemu/bswap.h: In function 'lduw_p': /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: implicit declaration of function 'memcpy' [-Wimplicit-function-declaration] /home/alexey/qemu/include/qemu/bswap.h:244:5: warning: incompatible implicit declaration of built-in function 'memcpy' [enabled by default] Signed-off-by: Alexey Kardashevskiy --- include/qemu/bswap.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h index d3af35d..d50de0d 100644 --- a/include/qemu/bswap.h +++ b/include/qemu/bswap.h @@ -1,6 +1,8 @@ #ifndef BSWAP_H #define BSWAP_H +#include + #include "config-host.h" #include #include -- 1.7.10.4