From: mrhines@linux.vnet.ibm.com
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mst@redhat.com, owasserm@redhat.com,
abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 4/8] rdma: implement new QEMUFileOps hooks
Date: Fri, 12 Apr 2013 01:52:05 -0400 [thread overview]
Message-ID: <1365745929-24871-5-git-send-email-mrhines@linux.vnet.ibm.com> (raw)
In-Reply-To: <1365745929-24871-3-git-send-email-mrhines@linux.vnet.ibm.com>
From: "Michael R. Hines" <mrhines@us.ibm.com>
These are the actual definitions of the accessor methods
which call out to QEMUFileOps hooks during the RAM
iteration faces. These hooks are accessed by
arch_init.c, which comes later in the patch series.
Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
---
savevm.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 74 insertions(+), 7 deletions(-)
diff --git a/savevm.c b/savevm.c
index b1d8988..fb452fc 100644
--- a/savevm.c
+++ b/savevm.c
@@ -409,14 +409,23 @@ static const QEMUFileOps socket_write_ops = {
.close = socket_close
};
-QEMUFile *qemu_fopen_socket(int fd, const char *mode)
+bool qemu_file_mode_is_not_valid(const char *mode)
{
- QEMUFileSocket *s = g_malloc0(sizeof(QEMUFileSocket));
-
if (mode == NULL ||
(mode[0] != 'r' && mode[0] != 'w') ||
mode[1] != 'b' || mode[2] != 0) {
fprintf(stderr, "qemu_fopen: Argument validity check failed\n");
+ return true;
+ }
+
+ return false;
+}
+
+QEMUFile *qemu_fopen_socket(int fd, const char *mode)
+{
+ QEMUFileSocket *s = g_malloc0(sizeof(QEMUFileSocket));
+
+ if (qemu_file_mode_is_not_valid(mode)) {
return NULL;
}
@@ -434,10 +443,7 @@ QEMUFile *qemu_fopen(const char *filename, const char *mode)
{
QEMUFileStdio *s;
- if (mode == NULL ||
- (mode[0] != 'r' && mode[0] != 'w') ||
- mode[1] != 'b' || mode[2] != 0) {
- fprintf(stderr, "qemu_fopen: Argument validity check failed\n");
+ if (qemu_file_mode_is_not_valid(mode)) {
return NULL;
}
@@ -554,6 +560,67 @@ static void qemu_fflush(QEMUFile *f)
}
}
+void ram_control_before_iterate(QEMUFile *f, uint32_t flags)
+{
+ int ret = 0;
+
+ if (f->ops->before_ram_iterate) {
+ qemu_fflush(f);
+ ret = f->ops->before_ram_iterate(f, f->opaque, flags);
+ if (ret < 0) {
+ qemu_file_set_error(f, ret);
+ }
+ }
+}
+
+void ram_control_after_iterate(QEMUFile *f, uint32_t flags)
+{
+ int ret = 0;
+
+ if (f->ops->after_ram_iterate) {
+ qemu_fflush(f);
+ ret = f->ops->after_ram_iterate(f, f->opaque, flags);
+ if (ret < 0) {
+ qemu_file_set_error(f, ret);
+ }
+ }
+}
+
+void ram_control_load_hook(QEMUFile *f, uint32_t flags)
+{
+ int ret = 0;
+
+ if (f->ops->hook_ram_load) {
+ qemu_fflush(f);
+ ret = f->ops->hook_ram_load(f, f->opaque, flags);
+ if (ret < 0) {
+ qemu_file_set_error(f, ret);
+ }
+ }
+}
+
+size_t ram_control_save_page(QEMUFile *f,
+ ram_addr_t block_offset,
+ ram_addr_t offset,
+ size_t size, uint8_t *va)
+{
+ if (f->ops->save_page) {
+ size_t bytes;
+
+ qemu_fflush(f);
+
+ bytes = f->ops->save_page(f, f->opaque, block_offset, offset, size, va);
+
+ if (bytes > 0) {
+ f->pos += bytes;
+ }
+
+ return bytes;
+ }
+
+ return -1;
+}
+
static void qemu_fill_buffer(QEMUFile *f)
{
int len;
--
1.7.10.4
next prev parent reply other threads:[~2013-04-12 5:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 5:52 [Qemu-devel] [PATCH 2/8] rdma: core rdma logic mrhines
2013-04-12 5:52 ` [Qemu-devel] [PATCH 3/8] rdma: new QEMUFileOps hooks mrhines
2013-04-12 11:02 ` Paolo Bonzini
2013-04-12 13:30 ` Michael R. Hines
2013-04-12 5:52 ` mrhines [this message]
2013-04-12 11:05 ` [Qemu-devel] [PATCH 4/8] rdma: implement " Paolo Bonzini
2013-04-12 13:01 ` Michael R. Hines
2013-04-12 5:52 ` [Qemu-devel] [PATCH 5/8] rdma: introduce capability for chunk registration mrhines
2013-04-12 5:52 ` [Qemu-devel] [PATCH 6/8] rdma: send pc.ram mrhines
2013-04-12 5:52 ` [Qemu-devel] [PATCH 7/8] rdma: print out throughput while debugging mrhines
2013-04-12 5:52 ` [Qemu-devel] [PATCH 8/8] rdma: add documentation mrhines
2013-04-12 11:10 ` [Qemu-devel] [PATCH 2/8] rdma: core rdma logic Paolo Bonzini
2013-04-12 13:29 ` Michael R. Hines
2013-04-12 13:41 ` Paolo Bonzini
2013-04-12 13:49 ` Michael R. Hines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1365745929-24871-5-git-send-email-mrhines@linux.vnet.ibm.com \
--to=mrhines@linux.vnet.ibm.com \
--cc=abali@us.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=gokul@us.ibm.com \
--cc=mrhines@us.ibm.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).