* [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message
@ 2013-04-12 6:46 Wanlong Gao
2013-04-15 18:39 ` Alex Williamson
0 siblings, 1 reply; 3+ messages in thread
From: Wanlong Gao @ 2013-04-12 6:46 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, alex.williamson, Wanlong Gao
While DEBUG() already includes the function name.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
hw/i386/kvm/pci-assign.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index c1e08ec..6afb82e 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr)
uint32_t r;
r = *in;
- DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
return r;
}
@@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr)
uint32_t r;
r = *in;
- DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
return r;
}
@@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr)
uint32_t r;
r = *in;
- DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
return r;
}
@@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val)
AssignedDevRegion *d = opaque;
uint8_t *out = d->u.r_virtbase + addr;
- DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
*out = val;
}
@@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val)
AssignedDevRegion *d = opaque;
uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr);
- DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
*out = val;
}
@@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val)
AssignedDevRegion *d = opaque;
uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr);
- DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
+ DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
*out = val;
}
--
1.8.2.1.339.g52a3e01
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message
2013-04-12 6:46 [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message Wanlong Gao
@ 2013-04-15 18:39 ` Alex Williamson
2013-05-28 2:25 ` Wanlong Gao
0 siblings, 1 reply; 3+ messages in thread
From: Alex Williamson @ 2013-04-15 18:39 UTC (permalink / raw)
To: Wanlong Gao; +Cc: pbonzini, qemu-devel
On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote:
> While DEBUG() already includes the function name.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> hw/i386/kvm/pci-assign.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Acked-by: Alex Williamson <alex.williamson@redhat.com>
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index c1e08ec..6afb82e 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr)
> uint32_t r;
>
> r = *in;
> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>
> return r;
> }
> @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint8_t *out = d->u.r_virtbase + addr;
>
> - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
> *out = val;
> }
>
> @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
> *out = val;
> }
>
> @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val)
> AssignedDevRegion *d = opaque;
> uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr);
>
> - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
> *out = val;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message
2013-04-15 18:39 ` Alex Williamson
@ 2013-05-28 2:25 ` Wanlong Gao
0 siblings, 0 replies; 3+ messages in thread
From: Wanlong Gao @ 2013-05-28 2:25 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Alex Williamson
Ping...
> On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote:
>> While DEBUG() already includes the function name.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> ---
>> hw/i386/kvm/pci-assign.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
>
>>
>> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
>> index c1e08ec..6afb82e 100644
>> --- a/hw/i386/kvm/pci-assign.c
>> +++ b/hw/i386/kvm/pci-assign.c
>> @@ -226,7 +226,7 @@ static uint32_t slow_bar_readb(void *opaque, hwaddr addr)
>> uint32_t r;
>>
>> r = *in;
>> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>>
>> return r;
>> }
>> @@ -238,7 +238,7 @@ static uint32_t slow_bar_readw(void *opaque, hwaddr addr)
>> uint32_t r;
>>
>> r = *in;
>> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>>
>> return r;
>> }
>> @@ -250,7 +250,7 @@ static uint32_t slow_bar_readl(void *opaque, hwaddr addr)
>> uint32_t r;
>>
>> r = *in;
>> - DEBUG("slow_bar_readl addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, r);
>>
>> return r;
>> }
>> @@ -260,7 +260,7 @@ static void slow_bar_writeb(void *opaque, hwaddr addr, uint32_t val)
>> AssignedDevRegion *d = opaque;
>> uint8_t *out = d->u.r_virtbase + addr;
>>
>> - DEBUG("slow_bar_writeb addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%02x\n", addr, val);
>> *out = val;
>> }
>>
>> @@ -269,7 +269,7 @@ static void slow_bar_writew(void *opaque, hwaddr addr, uint32_t val)
>> AssignedDevRegion *d = opaque;
>> uint16_t *out = (uint16_t *)(d->u.r_virtbase + addr);
>>
>> - DEBUG("slow_bar_writew addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%04x\n", addr, val);
>> *out = val;
>> }
>>
>> @@ -278,7 +278,7 @@ static void slow_bar_writel(void *opaque, hwaddr addr, uint32_t val)
>> AssignedDevRegion *d = opaque;
>> uint32_t *out = (uint32_t *)(d->u.r_virtbase + addr);
>>
>> - DEBUG("slow_bar_writel addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
>> + DEBUG("addr=0x" TARGET_FMT_plx " val=0x%08x\n", addr, val);
>> *out = val;
>> }
>>
>
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-28 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-12 6:46 [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message Wanlong Gao
2013-04-15 18:39 ` Alex Williamson
2013-05-28 2:25 ` Wanlong Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).